Skip to content

fixed 4 Test Classes - #85

Merged
axymthr merged 3 commits into
developfrom
test-framework-fix
Nov 16, 2025
Merged

fixed 4 Test Classes#85
axymthr merged 3 commits into
developfrom
test-framework-fix

Conversation

@anuragSharma1112

@anuragSharma1112 anuragSharma1112 commented Nov 14, 2025

Copy link
Copy Markdown
Collaborator

Description

Introduced an application-test.yml under src/test/resources to configure an in-memory SQLite database (jdbc:sqlite:memory:testdb?cache=shared) with Hibernate create-drop strategy and disabled Flyway migrations for test runs. This setup ensures isolated, lightweight database testing without external dependencies.
Also remove the earlier saperate Wiremock Service Impl and have created a test class for the WireMock Integration Test with Graph Email.

Fixes # (issue)
Test Classes Fixed

Please delete options that are not relevant.

How Has This Been Tested?

  • Unit Tests
  • Integration Tests
  • Manual Testing (please describe)

Checklist:

  • I have created ADR (Architecture Decision Record) for this change, in case of architecture or tech stack changes.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes in other branches have been merged
  • I have updated the relevant application properties files (if needed)
  • I have updated any necessary database migrations (if needed)

Screenshots (for UX changes):

NA

Additional Notes:

All test classes are passed and build is green now, as i have created a application-test.yml and also handle the profiles and resolved the wiremock service as well and created a robust test class for wiremock Integration test with GraphEmail.

@anuragSharma1112

Copy link
Copy Markdown
Collaborator Author

Hi @axymthr plz review

Comment thread web-backend/src/test/java/com/statusneo/vms/config/TestConfig.java Outdated
@anuragSharma1112

Copy link
Copy Markdown
Collaborator Author

Hi @axymthr sir,
I corrected all failing test cases across the project. Since the build only passes when all related files are fixed together, pushing them in smaller batches (2–3 files at a time) would have caused the build to fail repeatedly.
To ensure a clean, successful CI/CD build, I fixed all affected files and committed them in one go.

@axymthr axymthr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good. The framework support is being used aptly. I think the Wiremock usage could be tweaked more so we don't have to do as much manual mocking, but let's do that in a separate PR.

@axymthr
axymthr merged commit 71f43e6 into develop Nov 16, 2025
5 checks passed
@axymthr
axymthr deleted the test-framework-fix branch November 16, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants