fixed 4 Test Classes - #85
Merged
Merged
Conversation
Collaborator
Author
|
Hi @axymthr plz review |
axymthr
requested changes
Nov 14, 2025
Collaborator
Author
|
Hi @axymthr sir, |
axymthr
approved these changes
Nov 16, 2025
axymthr
left a comment
Contributor
There was a problem hiding this comment.
PR looks good. The framework support is being used aptly. I think the Wiremock usage could be tweaked more so we don't have to do as much manual mocking, but let's do that in a separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduced an application-test.yml under src/test/resources to configure an in-memory SQLite database (jdbc:sqlite:memory:testdb?cache=shared) with Hibernate create-drop strategy and disabled Flyway migrations for test runs. This setup ensures isolated, lightweight database testing without external dependencies.
Also remove the earlier saperate Wiremock Service Impl and have created a test class for the WireMock Integration Test with Graph Email.
Fixes # (issue)
Test Classes Fixed
Please delete options that are not relevant.
How Has This Been Tested?
Checklist:
Screenshots (for UX changes):
NA
Additional Notes:
All test classes are passed and build is green now, as i have created a application-test.yml and also handle the profiles and resolved the wiremock service as well and created a robust test class for wiremock Integration test with GraphEmail.