Skip to content

Conversation

@LaserYGD
Copy link
Contributor

SteamDB app page links to a few games using this

https://steamdb.info/app/1307550
https://steamdb.info/app/1062090
https://steamdb.info/app/1158370/

Brief explanation of the change

Adds unity's Universal Render Pipeline, which is a Scriptable render pipeline. Unity has two, HDRP and URP, and they're the new and supported 'graphic' backends of unity. The old one is on long-term bug fixing only.
View #96 for more info.

@xPaw
Copy link
Member

xPaw commented Sep 20, 2021

FYI, you didn't need to make a new PR to fix up your previous one by just force pushing to that branch.

Take a look at the tests to see the failures.

@@ -0,0 +1 @@
[**URP**](https://docs.unity3d.com/Packages/com.unity.render-pipelines.universal@11.0/manual/index.html) The Universal Render Pipeline is a prebuilt Scriptable Render Pipeline, made by Unity. URP provides artist-friendly workflows that let you quickly and easily create optimized graphics across a range of platforms, from mobile to high-end consoles and PCs. No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@LaserYGD LaserYGD Sep 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a little better wording otherwise URP is out of place: https://github.com/SteamDatabase/FileDetectionRuleSets/blob/349b13bb5674a8ce07f32af6c99cbae245ee6d40/descriptions/SDK.UnityURP.md

  1. URP Is a cross-platform Scriptable Render Pipeline built by Unity with the intent of a wide platform support range.
  2. URP is a cross-platform Scriptable Render Pipeline built by Unity to target all modern platforms with a low performance overhead.
  3. URP is a cross-platform Scriptable Render Pipeline built by Unity to target all modern platforms, while providing a capability to achieve high-fidelity graphics.

And a few others. Not really sure what to choose.
URP is similar to HDRP but with a focus on supporting all platforms (Mobile, Switch, PCs, Consoles) where HDRP is focused on extremely high graphics and platform support for powerful hardware only (Next-gen consoles, PCs).

But URP is 'universal', in it that you can still achieve good looking visuals. Just not as good as HDRP, and harder without custom tools or assets. Where HDRP has it all provided by the engine.

@LaserYGD
Copy link
Contributor Author

FYI, you didn't need to make a new PR to fix up your previous one by just force pushing to that branch.

Take a look at the tests to see the failures.

I understand, but after some beginner struggles I decided to take the less frustrating route. I really need to take sometime to actually learn git, and stop brute forcing 😅

will fix now

@LaserYGD
Copy link
Contributor Author

tests passing, description updated
I've added a particular game I confirmed to be using URP but are using il2cpp so steamdb can't pick it up.
There's many popular games doing the same thing with HDRP, I intend to do it for that as well

@LaserYGD
Copy link
Contributor Author

all review commits done

@xPaw xPaw merged commit cc27276 into SteamDatabase:main Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants