-
Notifications
You must be signed in to change notification settings - Fork 171
Convert pipelines to GitHub Actions #1535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c0aca5f to
c184264
Compare
569ada9 to
cfe645f
Compare
b7762d6 to
49548dc
Compare
383e6d7 to
ad4058d
Compare
Summary - All Code Coverage (ubuntu-latest)
|
c65d3e9 to
7dc3711
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR replaces legacy Azure DevOps pipelines with GitHub Actions workflows, updating build, test, code style, and coverage reporting configurations while removing outdated pipeline files.
- Introduces multiple GitHub Actions workflow files to run builds and tests across different OS environments.
- Updates test projects with new traits (e.g., SkipOnMacOS) and refactors certain assertions.
- Removes unused Azure Pipelines YAML files and related templates.
Reviewed Changes
Copilot reviewed 35 out of 35 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Steeltoe.All.sln | Removed legacy Azure Pipelines solution items. |
| src/Security/test/Authorization.Certificate.Test.cs | Added SkipOnMacOS traits for specific certificate tests. |
| src/Management/src/Tasks/Properties/AssemblyInfo.cs | Removed DynamicProxyGenAssembly2 attribute. |
| src/Management/src/Endpoint/Properties/AssemblyInfo.cs | Removed DynamicProxyGenAssembly2 attribute. |
| src/Management/src/Endpoint/Actuators/ThreadDump/EventPipeThreadDumper.cs | Minor formatting update with an extra blank line. |
| src/Discovery/test/* | Added SkipOnMacOS traits in several discovery tests. |
| src/Common/test/Net.Test/WindowsNetworkFileShareTest.cs | Converted assertions to FluentAssertions with refined error messages. |
| src/Common/test/Certificates.Test/ConfigureCertificateOptionsTest.cs | Added SkipOnMacOS trait for certificate configuration tests. |
| src/Common/src/Common/ConfigurationSchemaAttributes.cs | Added ExcludeFromCodeCoverage attribute with justification. |
| build/* | Removed Azure Pipelines YAML configuration files. |
| .github/workflows/* | Added GitHub Actions workflows for code style, build, test, coverage, and component builds. |
Comments suppressed due to low confidence (2)
.github/workflows/component-shared-workflow.yml:66
- Consider standardizing OS identifiers across workflows; using 'macos' here may be inconsistent with other workflows that reference 'macos-latest' or 'macOS'.
if: ${{ inputs.OS == 'macos' }}
.github/workflows/Steeltoe.All.yml:152
- Ensure the GitHub CLI is installed and available in the runner environment to prevent failures in the PR comment step.
run: gh pr comment $PR_NUMBER --edit-last --create-if-none --body-file coveragereport/Summary.md
7926038 to
ea56bbc
Compare
TimHess
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! I'm looking forward to having these all closer to the code/PR
Addressing the two listed items is optional
|



Description
Adds GitHub Actions workflows for Steeltoe.All and Sonar. PR diff coverage is reported by Sonar, full branch coverage in a PR comment (summarized) and in the build summary (detailed).
Fixes the upload of crash/hang dumps during test runs.
Removes old Azure DevOps pipelines.
Packaging still uses Azure DevOps, to be addressed in a subsequent PR.
Note
This PR contains reverted commits to test various kinds of scenarios.
Quality checklist
If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.