Skip to content

Conversation

@bart-vmware
Copy link
Member

@bart-vmware bart-vmware commented Jun 23, 2025

Description

Adds GitHub Actions workflows for Steeltoe.All and Sonar. PR diff coverage is reported by Sonar, full branch coverage in a PR comment (summarized) and in the build summary (detailed).
Fixes the upload of crash/hang dumps during test runs.
Removes old Azure DevOps pipelines.

Packaging still uses Azure DevOps, to be addressed in a subsequent PR.

Note

This PR contains reverted commits to test various kinds of scenarios.

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@bart-vmware bart-vmware force-pushed the github-actions branch 2 times, most recently from c0aca5f to c184264 Compare June 23, 2025 12:15
@SteeltoeOSS SteeltoeOSS deleted a comment from sonarqubecloud bot Jun 23, 2025
@SteeltoeOSS SteeltoeOSS deleted a comment from sonarqubecloud bot Jun 23, 2025
@bart-vmware bart-vmware force-pushed the github-actions branch 2 times, most recently from b7762d6 to 49548dc Compare June 23, 2025 13:59
@SteeltoeOSS SteeltoeOSS deleted a comment from sonarqubecloud bot Jun 23, 2025
@SteeltoeOSS SteeltoeOSS deleted a comment from sonarqubecloud bot Jun 24, 2025
@bart-vmware bart-vmware force-pushed the github-actions branch 3 times, most recently from 383e6d7 to ad4058d Compare June 25, 2025 13:31
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Jun 26, 2025
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Jun 26, 2025
@SteeltoeOSS SteeltoeOSS deleted a comment from sonarqubecloud bot Jun 26, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 26, 2025

Summary - All Code Coverage (ubuntu-latest)

Line coverage Branch coverage

Assembly Line coverage Branch coverage
Steeltoe.Bootstrap.AutoConfiguration 97.4% 100%
Steeltoe.Common 85.6% 79.8%
Steeltoe.Common.Certificates 96.2% 85.2%
Steeltoe.Common.Hosting 84% 70%
Steeltoe.Common.Http 100% 85.2%
Steeltoe.Common.Logging 80.4% 41.6%
Steeltoe.Common.Net 64.5% 66.6%
Steeltoe.Configuration.Abstractions 97.8% 92.6%
Steeltoe.Configuration.CloudFoundry 99.1% 91.6%
Steeltoe.Configuration.ConfigServer 97.2% 91.5%
Steeltoe.Configuration.Encryption 97.6% 92.4%
Steeltoe.Configuration.Kubernetes.ServiceBindings 95.1% 89.3%
Steeltoe.Configuration.Placeholder 93.8% 84.7%
Steeltoe.Configuration.RandomValue 93.2% 90%
Steeltoe.Configuration.SpringBoot 98.4% 95.4%
Steeltoe.Connectors 94.8% 90%
Steeltoe.Connectors.EntityFrameworkCore 81.5% 75%
Steeltoe.Discovery.Configuration 90.4% 100%
Steeltoe.Discovery.Consul 97.7% 94.8%
Steeltoe.Discovery.Eureka 92.6% 85.5%
Steeltoe.Discovery.HttpClients 94% 95.4%
Steeltoe.Logging.Abstractions 99.4% 96.9%
Steeltoe.Logging.DynamicConsole 100% 95.4%
Steeltoe.Logging.DynamicSerilog 99.1% 95%
Steeltoe.Management.Abstractions 100% 100%
Steeltoe.Management.Endpoint 95.5% 89.1%
Steeltoe.Management.Prometheus 95.9% 91.6%
Steeltoe.Management.Tasks 100% ****
Steeltoe.Management.Tracing 100% 75%
Steeltoe.Security.Authentication.JwtBearer 100% 100%
Steeltoe.Security.Authentication.OpenIdConnect 73.8% 59%
Steeltoe.Security.Authorization.Certificate 96.3% 75%
Steeltoe.Security.DataProtection.Redis 100% ****

@bart-vmware bart-vmware force-pushed the github-actions branch 11 times, most recently from c65d3e9 to 7dc3711 Compare July 1, 2025 13:00
@bart-vmware bart-vmware marked this pull request as ready for review July 1, 2025 13:22
@bart-vmware bart-vmware requested review from TimHess and Copilot July 1, 2025 13:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces legacy Azure DevOps pipelines with GitHub Actions workflows, updating build, test, code style, and coverage reporting configurations while removing outdated pipeline files.

  • Introduces multiple GitHub Actions workflow files to run builds and tests across different OS environments.
  • Updates test projects with new traits (e.g., SkipOnMacOS) and refactors certain assertions.
  • Removes unused Azure Pipelines YAML files and related templates.

Reviewed Changes

Copilot reviewed 35 out of 35 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Steeltoe.All.sln Removed legacy Azure Pipelines solution items.
src/Security/test/Authorization.Certificate.Test.cs Added SkipOnMacOS traits for specific certificate tests.
src/Management/src/Tasks/Properties/AssemblyInfo.cs Removed DynamicProxyGenAssembly2 attribute.
src/Management/src/Endpoint/Properties/AssemblyInfo.cs Removed DynamicProxyGenAssembly2 attribute.
src/Management/src/Endpoint/Actuators/ThreadDump/EventPipeThreadDumper.cs Minor formatting update with an extra blank line.
src/Discovery/test/* Added SkipOnMacOS traits in several discovery tests.
src/Common/test/Net.Test/WindowsNetworkFileShareTest.cs Converted assertions to FluentAssertions with refined error messages.
src/Common/test/Certificates.Test/ConfigureCertificateOptionsTest.cs Added SkipOnMacOS trait for certificate configuration tests.
src/Common/src/Common/ConfigurationSchemaAttributes.cs Added ExcludeFromCodeCoverage attribute with justification.
build/* Removed Azure Pipelines YAML configuration files.
.github/workflows/* Added GitHub Actions workflows for code style, build, test, coverage, and component builds.
Comments suppressed due to low confidence (2)

.github/workflows/component-shared-workflow.yml:66

  • Consider standardizing OS identifiers across workflows; using 'macos' here may be inconsistent with other workflows that reference 'macos-latest' or 'macOS'.
      if: ${{ inputs.OS == 'macos' }}

.github/workflows/Steeltoe.All.yml:152

  • Ensure the GitHub CLI is installed and available in the runner environment to prevent failures in the PR comment step.
      run: gh pr comment $PR_NUMBER --edit-last --create-if-none --body-file coveragereport/Summary.md

@bart-vmware bart-vmware marked this pull request as draft July 1, 2025 13:57
@bart-vmware bart-vmware marked this pull request as ready for review July 1, 2025 14:00
TimHess
TimHess previously approved these changes Jul 1, 2025
Copy link
Member

@TimHess TimHess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I'm looking forward to having these all closer to the code/PR

Addressing the two listed items is optional

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 1, 2025

@bart-vmware bart-vmware merged commit 7dab86d into main Jul 2, 2025
20 checks passed
@bart-vmware bart-vmware deleted the github-actions branch July 2, 2025 09:41
@bart-vmware bart-vmware added this to the 4.0.0-rc1 milestone Jul 10, 2025
@bart-vmware bart-vmware added the ReleaseLine/4.x Identified as a feature/fix for the 4.x release line label Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ReleaseLine/4.x Identified as a feature/fix for the 4.x release line

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants