Skip to content

Fix CA1873: Potentially expensive logging#1695

Merged
bart-vmware merged 3 commits into
mainfrom
fix-expensive-logging
May 13, 2026
Merged

Fix CA1873: Potentially expensive logging#1695
bart-vmware merged 3 commits into
mainfrom
fix-expensive-logging

Conversation

@bart-vmware
Copy link
Copy Markdown
Member

@bart-vmware bart-vmware commented May 12, 2026

Description

Follow-up of #1652.

Additionally, masks the username/password in URLs returned from the HTTP exchanges actuator.

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2026

Summary - All Code Coverage (ubuntu-latest)

Line coverage Branch coverage

Assembly Line coverage Branch coverage
Steeltoe.Bootstrap.AutoConfiguration 97.4% 100%
Steeltoe.Common 86.4% 77.8%
Steeltoe.Common.Certificates 97.2% 85.9%
Steeltoe.Common.Hosting 83.5% 65%
Steeltoe.Common.Http 97.4% 83.3%
Steeltoe.Common.Logging 81.1% 56.2%
Steeltoe.Common.Net 64.5% 66.6%
Steeltoe.Configuration.Abstractions 96.6% 92.8%
Steeltoe.Configuration.CloudFoundry 98.3% 93.9%
Steeltoe.Configuration.ConfigServer 91.1% 87.8%
Steeltoe.Configuration.Encryption 97.6% 92.4%
Steeltoe.Configuration.Kubernetes.ServiceBindings 95.1% 89.3%
Steeltoe.Configuration.Placeholder 93.8% 84.7%
Steeltoe.Configuration.RandomValue 93.2% 90%
Steeltoe.Configuration.SpringBoot 98.3% 95%
Steeltoe.Connectors 94.5% 90.7%
Steeltoe.Connectors.EntityFrameworkCore 79.7% 65.3%
Steeltoe.Discovery.Configuration 96.3% 75%
Steeltoe.Discovery.Consul 91.5% 91.3%
Steeltoe.Discovery.Eureka 91.1% 84.2%
Steeltoe.Discovery.HttpClients 89.9% 94.2%
Steeltoe.Logging.Abstractions 99.4% 97.1%
Steeltoe.Logging.DynamicConsole 100% 96.1%
Steeltoe.Logging.DynamicSerilog 99.1% 95.4%
Steeltoe.Management.Abstractions 100% 100%
Steeltoe.Management.Endpoint 95.9% 89.5%
Steeltoe.Management.Prometheus 95.8% 91.6%
Steeltoe.Management.Tasks 95.2% 80%
Steeltoe.Management.Tracing 100% 75%
Steeltoe.Security.Authentication.JwtBearer 98.1% 96.1%
Steeltoe.Security.Authentication.OpenIdConnect 76% 58.3%
Steeltoe.Security.Authorization.Certificate 95.6% 73%
Steeltoe.Security.DataProtection.Redis 100% ****

@bart-vmware bart-vmware marked this pull request as ready for review May 12, 2026 13:36
@bart-vmware bart-vmware requested a review from TimHess May 12, 2026 13:36
@bart-vmware bart-vmware force-pushed the fix-expensive-logging branch from 985e7f3 to 17a13fd Compare May 12, 2026 15:02
Comment thread src/Discovery/src/Eureka/EurekaClient.cs Outdated
@bart-vmware bart-vmware requested a review from TimHess May 13, 2026 10:27
Copy link
Copy Markdown
Member

@TimHess TimHess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bart-vmware bart-vmware force-pushed the fix-expensive-logging branch from 2992a9c to 8b3b5d2 Compare May 13, 2026 15:05
@sonarqubecloud
Copy link
Copy Markdown

@bart-vmware bart-vmware merged commit f4d5993 into main May 13, 2026
25 checks passed
@bart-vmware bart-vmware deleted the fix-expensive-logging branch May 13, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants