Conversation
Codecov Report
@@ Coverage Diff @@
## master #588 +/- ##
==========================================
+ Coverage 63.09% 63.12% +0.02%
==========================================
Files 1290 1290
Lines 42964 42971 +7
Branches 8478 8480 +2
==========================================
+ Hits 27108 27124 +16
+ Misses 13534 13523 -11
- Partials 2322 2324 +2
Continue to review full report at Codecov.
|
2871010 to
ec83ba0
Compare
ec83ba0 to
1abaa7f
Compare
TimHess
approved these changes
Feb 3, 2021
|
SonarCloud Quality Gate failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if SSO service bindings are not found during CloudFoundry OAuth extension or CloudFoundry JWT Bearer extension, default URL are kept and not leveraging the current auth domain setting (if available). OAuth URL domains should default to Auth Domain app setting if SSO service bindings are not available.
Addresses #578 for 3.x