Skip to content

OAuth Service URL Fallback (3.x version)#588

Merged
kenswan merged 3 commits intomasterfrom
oauth-config-3x
Feb 3, 2021
Merged

OAuth Service URL Fallback (3.x version)#588
kenswan merged 3 commits intomasterfrom
oauth-config-3x

Conversation

@kenswan
Copy link
Copy Markdown
Contributor

@kenswan kenswan commented Feb 3, 2021

Currently, if SSO service bindings are not found during CloudFoundry OAuth extension or CloudFoundry JWT Bearer extension, default URL are kept and not leveraging the current auth domain setting (if available). OAuth URL domains should default to Auth Domain app setting if SSO service bindings are not available.

Addresses #578 for 3.x

@kenswan kenswan added Type/enhancement New feature or request Component/Security Issues related to Steeltoe Security components (not app-sec) ReleaseLine/3.x Identified as a feature/fix for the 3.x release line labels Feb 3, 2021
@kenswan kenswan added this to the 3.1.0 milestone Feb 3, 2021
@kenswan kenswan self-assigned this Feb 3, 2021
@kenswan kenswan linked an issue Feb 3, 2021 that may be closed by this pull request
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 3, 2021

Codecov Report

Merging #588 (1abaa7f) into master (5fcfc2f) will increase coverage by 0.02%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #588      +/-   ##
==========================================
+ Coverage   63.09%   63.12%   +0.02%     
==========================================
  Files        1290     1290              
  Lines       42964    42971       +7     
  Branches     8478     8480       +2     
==========================================
+ Hits        27108    27124      +16     
+ Misses      13534    13523      -11     
- Partials     2322     2324       +2     
Impacted Files Coverage Δ
...loudFoundryCore/AuthenticationBuilderExtensions.cs 57.77% <66.66%> (-0.85%) ⬇️
...n.CloudFoundryCore/CloudFoundryJwtBearerOptions.cs 85.71% <75.00%> (-5.96%) ⬇️
...ation.CloudFoundryCore/CloudFoundryOAuthOptions.cs 81.25% <100.00%> (+4.58%) ⬆️
...n/src/Common/Converter/GenericConversionService.cs 71.73% <0.00%> (-1.09%) ⬇️
...ation.CloudFoundryCore/CloudFoundryOAuthHandler.cs 60.46% <0.00%> (ø)
...FoundryCore/CloudFoundryOpenIdConnectConfigurer.cs 73.46% <0.00%> (ø)
...rc/RabbitMQ/Connection/CachingConnectionFactory.cs 55.84% <0.00%> (+0.26%) ⬆️
...abbitMQ/Listener/DirectMessageListenerContainer.cs 52.83% <0.00%> (+0.32%) ⬆️
...c/Messaging/src/RabbitMQ/Connection/RabbitUtils.cs 42.22% <0.00%> (+1.48%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fcfc2f...1abaa7f. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 3, 2021

@kenswan kenswan merged commit 14af818 into master Feb 3, 2021
@kenswan kenswan deleted the oauth-config-3x branch February 3, 2021 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component/Security Issues related to Steeltoe Security components (not app-sec) ReleaseLine/3.x Identified as a feature/fix for the 3.x release line Type/enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OAuth Service Binding URLs

2 participants