Skip to content

Hystrix tests#88

Merged
TimHess merged 32 commits into
2.xfrom
hystrix-tests
Aug 1, 2019
Merged

Hystrix tests#88
TimHess merged 32 commits into
2.xfrom
hystrix-tests

Conversation

@TimHess
Copy link
Copy Markdown
Member

@TimHess TimHess commented Jul 25, 2019

This PR should provide more consistently successful tests on all platforms and make it easier to pinpoint more failures

@cf-gitbot
Copy link
Copy Markdown

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/167522444

The labels on this github issue will be updated when the story is started.

@TimHess TimHess requested a review from ddieruf July 25, 2019 19:37
hananiel
hananiel previously approved these changes Jul 25, 2019
Copy link
Copy Markdown
Contributor

@hananiel hananiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked at it best I could on my phone :)

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 25, 2019

Codecov Report

Merging #88 into 2.x will increase coverage by 6.05%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x      #88      +/-   ##
==========================================
+ Coverage   63.29%   69.34%   +6.05%     
==========================================
  Files         946      946              
  Lines       26695    26660      -35     
  Branches     4984     4979       -5     
==========================================
+ Hits        16896    18487    +1591     
+ Misses       8392     6723    -1669     
- Partials     1407     1450      +43
Impacted Files Coverage Δ
...ircuitBreaker/src/HystrixBase/HystrixRequestLog.cs 79.45% <ø> (+59.18%) ⬆️
...xBase/Strategy/Concurrency/HystrixTaskScheduler.cs 75.92% <100%> (+29.49%) ⬆️
...cuitBreaker/src/HystrixBase/Util/TimerReference.cs 100% <100%> (+100%) ⬆️
...er/src/HystrixBase/Util/SemaphoreSlimExtensions.cs 100% <100%> (+66.66%) ⬆️
...c/CircuitBreaker/src/HystrixBase/HystrixCommand.cs 64.76% <50%> (+38.59%) ⬆️
.../EndpointBase/DbMigrations/DbMigrationsEndpoint.cs 90.69% <85.71%> (-2.33%) ⬇️
...mmon/src/Common.Security/PemCertificateProvider.cs 71.42% <0%> (-14.29%) ⬇️
...intBase/Metrics/Observer/HttpClientCoreObserver.cs 56.16% <0%> (-13.7%) ⬇️
...Core/Metrics/Observer/AspNetCoreHostingObserver.cs 63.33% <0%> (-13.34%) ⬇️
...Core/Trace/EndpointApplicationBuilderExtensions.cs 62.5% <0%> (-4.17%) ⬇️
... and 88 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f90969...6526824. Read the comment docs.

@TimHess TimHess force-pushed the hystrix-tests branch 5 times, most recently from d406d80 to 46987c2 Compare August 1, 2019 01:03
more isolation and async in tests

skip "TestSingleTimeout"

ConfigureAwait(false) skip one more

SkipOnMacOS

skips/timings

skips/timings

don't await observables, dial back some dispose logic

Run() use lambda, set latency for "Timeout" commands back to 1000ms

skip tests
@TimHess TimHess merged commit b50dbef into 2.x Aug 1, 2019
@TimHess TimHess deleted the hystrix-tests branch August 1, 2019 20:50
@TimHess TimHess mentioned this pull request Aug 7, 2019
TimHess added a commit that referenced this pull request Aug 8, 2019
Changes to help test steps pass in CI
@TimHess TimHess added ReleaseLine/2.x Identified as a feature/fix for the 2.x release line Component/CircuitBreaker Issues related to Steeltoe.CircuitBreaker labels Sep 10, 2020
@TimHess TimHess self-assigned this Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component/CircuitBreaker Issues related to Steeltoe.CircuitBreaker ReleaseLine/2.x Identified as a feature/fix for the 2.x release line

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants