Hystrix tests#88
Merged
Merged
Conversation
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/167522444 The labels on this github issue will be updated when the story is started. |
hananiel
previously approved these changes
Jul 25, 2019
Contributor
hananiel
left a comment
There was a problem hiding this comment.
Looked at it best I could on my phone :)
Codecov Report
@@ Coverage Diff @@
## 2.x #88 +/- ##
==========================================
+ Coverage 63.29% 69.34% +6.05%
==========================================
Files 946 946
Lines 26695 26660 -35
Branches 4984 4979 -5
==========================================
+ Hits 16896 18487 +1591
+ Misses 8392 6723 -1669
- Partials 1407 1450 +43
Continue to review full report at Codecov.
|
added 2 commits
July 26, 2019 08:18
added 3 commits
July 29, 2019 15:13
… into hystrix-tests
d406d80 to
46987c2
Compare
more isolation and async in tests skip "TestSingleTimeout" ConfigureAwait(false) skip one more SkipOnMacOS skips/timings skips/timings don't await observables, dial back some dispose logic Run() use lambda, set latency for "Timeout" commands back to 1000ms skip tests
added 2 commits
August 1, 2019 13:49
hananiel
approved these changes
Aug 1, 2019
Closed
TimHess
added a commit
that referenced
this pull request
Aug 8, 2019
Changes to help test steps pass in CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should provide more consistently successful tests on all platforms and make it easier to pinpoint more failures