RC Fix: Localized Sky Culture Names in RemoteControl API

[kutaibaa-akraa]

@alex-w @gzotti @10110111

Issue

The RemoteControl plugin endpoint /api/view/listskyculture returns sky culture names in English only, regardless of Stellarium's UI language. This is inconsistent with other Endpoints as an example : /api/view/listlandscape and /api/view/listprojection which return properly localized names.

Inside file: plugins/RemoteControl/src/ViewService.cppLine 87 : should we replace getDirToNameMap() with getDirToI18Map() ??! Which already provides properly translated names using the sky culture translator !!!
you know better than me .

Targeted Line 87 :

stellarium/plugins/RemoteControl/src/ViewService.cpp

Lines 86 to 88 in c8c01b3

	//list installed skycultures
	QMap<QString, StelSkyCulture> map = skyCulMgr->getDirToNameMap();

Expected Result: When Stellarium UI language is set to Arabic, the endpoint now returns localized terms:

{
  "modern": "الحديث",
  "arabic_al-sufi": "العربي (الصوفي-كتاب الصوفي)",
  "chinese": "الصيني",
  "korean": "الكوري"
  ......
}

Instead of English-only names. The fix uses the existing StelSkyCultureMgr::getDirToI18Map() method which properly handles translation with the sky culture translator. The main sky culture panel in the RC interface will be populated with localized culture names, and will automatically reflect any changes when the GUI language is changed.

Your ideas please !

[alex-w]

The proposal solution isn't complete, but in any way the issue is fixed in master now.

[kutaibaa-akraa]

@alex-w

After fixing this : the image shows the localized skyculture names. thank you alex