Add increment kwarg to model.py's run() method#445
Merged
Conversation
…m/StochSS/GillesPy2 into incrementKwargFix
Member
|
This should throw an error if they both specify model.timespan and model.increment. |
ethangreen-dev
removed their request for review
June 25, 2021 21:30
Merged
ethangreen-dev
marked this pull request as ready for review
June 25, 2021 21:43
seanebum
approved these changes
Sep 14, 2021
Member
|
@jtcooper10 : raises an error if increment and self.timespan are both set... but self.timespan is always set, if the user doesn't provide a timespan then a timespan is created for them. So this approach will cause an error to be raised anytime that increment is provided, no matter what |
… incrementKwargFix
seanebum
approved these changes
Sep 20, 2021
…eck that ensures that both the tspan and increment are not set.
jtcooper10
requested changes
Sep 20, 2021
jtcooper10
left a comment
Collaborator
There was a problem hiding this comment.
Timespan set in constructor if not provided by the user, causing increment to raise an error. Conversely, removing the default construction of a timespan might be considered a breaking change.
BryanRumsey
marked this pull request as ready for review
September 20, 2021 21:27
seanebum
approved these changes
Sep 23, 2021
… incrementKwargFix
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows user to specify "increment" when running a model ex: model.run(solver=mysolver, increment=.01)
This functions the same as setting models timeline to something that will produce a specific increment, such as; numpy.linspace(0,100,10001) (increment of .01)