Skip to content

Model deprecation in solver.run #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
briandrawert merged 24 commits into from
Mar 29, 2022
Merged

Model deprecation in solver.run #754

briandrawert merged 24 commits into from
Mar 29, 2022

Conversation

@BryanRumsey
Copy link
Contributor

@BryanRumsey BryanRumsey commented Mar 23, 2022 •
edited
Loading

  • [#656]
    • When resume is passed to Model.run and the solver arg is omitted the solver is instantiated with variable=True.
  • [#751]
    • Solver constructors now require a model.
    • Added a deprecation warning alerting users that passing a model to Solver.run is not required.
  • [#752]
    • Added a deprecation warning alerting users that solver need to instantiated.
    • Solvers retrieved using Model.get_best_solver and Model.get_best_solver_algo are now instantiated prior to calling Solver.run.

@BryanRumsey BryanRumsey added the enhancement New feature or request label Mar 23, 2022
@BryanRumsey BryanRumsey added this to the 1.6.9 milestone Mar 23, 2022
@BryanRumsey BryanRumsey self-assigned this Mar 23, 2022
This was linked to issues Mar 23, 2022
model arg in solver.run needs to be deprecated #751
Closed
Solver must be instantiated prior to running #752
Closed
@BryanRumsey BryanRumsey changed the title Model dep in solver Model deprecation in solver.run Mar 23, 2022
@BryanRumsey BryanRumsey linked an issue Mar 28, 2022 that may be closed by this pull request
Pause/Resume for model.run() #656
Closed
briandrawert
briandrawert reviewed Mar 29, 2022
View reviewed changes
briandrawert
briandrawert reviewed Mar 29, 2022
View reviewed changes
This was referenced Mar 29, 2022
Closed
Closed
@briandrawert briandrawert self-requested a review March 29, 2022 15:20
@briandrawert briandrawert merged commit c9b578c into develop Mar 29, 2022
@BryanRumsey BryanRumsey mentioned this pull request Apr 14, 2022
Merged
@BryanRumsey BryanRumsey deleted the model-dep-in-solver branch May 3, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briandrawert briandrawert briandrawert approved these changes

@seanebum seanebum seanebum approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

1.6.9

Development

Successfully merging this pull request may close these issues.

Solver must be instantiated prior to running model arg in solver.run needs to be deprecated Pause/Resume for model.run()

4 participants

@BryanRumsey @briandrawert @seanebum