fix: replace process log SSE with incremental polling#1040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1039.
Root cause
The process Logs page automatically held an infinite
EventSourceresponse open. In the production path, the load balancer talks HTTP/1.1 to nginx; a stale/reused backend connection could retain that response and head-of-line block a later admin navigation, which explains the UI hanging after several tab changes.What changed
204 No Contentfrom the legacy stream route so pre-deploy EventSource clients stop reconnecting during rolloutContainer-log live follow remains explicitly user-activated, and image-pull event streams remain finite.
Validation
DOCKER_REGISTRY_PASSWORD=test cargo test -p ruscker-adminDOCKER_REGISTRY_PASSWORD=test cargo clippy --all-targets -- -D warnings./scripts/i18n-check.shgit diff --check