Skip to content

Stop ignoring SimplifyEmptyArrayCheckRector #2721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crabcyborg merged 2 commits into from
Jan 6, 2026
Merged

Stop ignoring SimplifyEmptyArrayCheckRector #2721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f53196f
Stop ignoring SimplifyEmptyArrayCheckRector
Crabcyborg Jan 6, 2026
16fbb87
Drop redundant braces
Crabcyborg Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion classes/helpers/FrmAppHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,7 +605,7 @@ public static function is_admin() {
* @return bool
*/
public static function is_empty_value( $value, $empty = '' ) {
return ( is_array( $value ) && empty( $value ) ) || $value === $empty;
return $value === array() || $value === $empty;
}

/**
Expand Down
2 changes: 1 addition & 1 deletion classes/models/FrmEntryMeta.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ public static function update_entry_metas( $entry_id, $values ) {

if ( $previous_field_ids && in_array( $field_id, $previous_field_ids ) ) {

if ( ( is_array( $meta_value ) && empty( $meta_value ) ) || ( ! is_array( $meta_value ) && trim( $meta_value ) === '' ) ) {
if ( $meta_value === array() || ( ! is_array( $meta_value ) && trim( $meta_value ) === '' ) ) {
// Remove blank fields.
unset( $values_indexed_by_field_id[ $field_id ] );
} else {
Expand Down
3 changes: 0 additions & 3 deletions rector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

// CodeQuality
use Rector\CodeQuality\Rector\Assign\CombinedAssignRector;
use Rector\CodeQuality\Rector\BooleanAnd\SimplifyEmptyArrayCheckRector;
use Rector\CodeQuality\Rector\Class_\CompleteDynamicPropertiesRector;
use Rector\CodeQuality\Rector\Class_\InlineConstructorDefaultToPropertyRector;
use Rector\CodeQuality\Rector\ClassMethod\LocallyCalledStaticMethodToNonStaticRector;
Expand Down Expand Up @@ -149,8 +148,6 @@
JoinStringConcatRector::class,
LocallyCalledStaticMethodToNonStaticRector::class,
ShortenElseIfRector::class,
// This changes if is_array() && empty() to if === [].
SimplifyEmptyArrayCheckRector::class,
SimplifyEmptyCheckOnEmptyArrayRector::class,
SimplifyRegexPatternRector::class,
SingleInArrayToCompareRector::class,
Expand Down
Loading