Stop passing unused param to captcha api check function

[Crabcyborg]

No description provided.

[coderabbitai]

Walkthrough

The send_api_check() method in FrmFieldCaptcha class had its $frm_settings parameter removed. The method call in validate_against_api() was updated to match the new signature, and documentation was updated accordingly.

Changes

Cohort / File(s)	Summary
Captcha API Validation classes/models/fields/FrmFieldCaptcha.php	Removed $frm_settings parameter from send_api_check() method signature and updated the corresponding method call in validate_against_api()

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No description was provided by the author, making it impossible to assess relevance to the changeset.	Add a pull request description explaining the motivation and impact of removing the unused parameter.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: removing an unused parameter from the captcha API check function call and method signature.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 541d06d and d19a40e.

📒 Files selected for processing (1)

• classes/models/fields/FrmFieldCaptcha.php

🔇 Additional comments (2)

classes/models/fields/FrmFieldCaptcha.php (2)

295-295: LGTM! Method call updated correctly.

The call to send_api_check() has been correctly updated to match the new signature without the unused parameter.

---

413-424: LGTM! Parameter correctly removed.

The $frm_settings parameter was unused in the method body, which already obtains captcha settings via FrmCaptchaFactory::get_settings_object(). Removing this parameter simplifies the method signature and eliminates unnecessary parameter passing. No subclasses of FrmFieldCaptcha exist in the codebase, and the only call to this method (line 295) passes no parameters.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}