Skip to content

Update eslint plugins (unicorn, sonarjs, jsdoc)#2990

Merged
Crabcyborg merged 1 commit into
masterfrom
update_eslint_plugins
Mar 2, 2026
Merged

Update eslint plugins (unicorn, sonarjs, jsdoc)#2990
Crabcyborg merged 1 commit into
masterfrom
update_eslint_plugins

Conversation

@Crabcyborg

@Crabcyborg Crabcyborg commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

Several are these rules were being flagged by oxlint but not in our eslint because we're on old versions.

Summary by CodeRabbit

  • Refactor

    • Simplified internal code structure by consolidating conditional logic for improved maintainability.
  • Chores

    • Upgraded multiple ESLint plugin dependencies to latest versions for enhanced development tooling.
    • Fine-tuned linting configuration settings to optimize code quality checks across the project.
    • Added webpack and associated build tools to development dependencies for improved build capabilities.

@deepsource-io

deepsource-io Bot commented Mar 2, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 8e70c1d...dcf29d5 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

Important

Some issues found as part of this review are outside of the diff in this pull request and aren't shown in the inline review comments due to GitHub's API limitations. You can see those issues on the DeepSource dashboard.

PR Report Card

Overall Grade  

Focus Area: Reliability
Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
PHP Mar 2, 2026 5:48p.m. Review ↗
JavaScript Mar 2, 2026 5:48p.m. Review ↗

@coderabbitai

coderabbitai Bot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

📥 Commits

Reviewing files that changed from the base of the PR and between 8e70c1d and dcf29d5.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (3)
  • eslint.config.mjs
  • js/src/admin/admin.js
  • package.json
 _________________
< Shell we dance? >
 -----------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ

✏️ Tip: You can disable in-progress messages and the fortune message in your review settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch update_eslint_plugins

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Crabcyborg Crabcyborg merged commit f9624df into master Mar 2, 2026
46 of 48 checks passed
@Crabcyborg Crabcyborg deleted the update_eslint_plugins branch March 2, 2026 17:51
stephywells pushed a commit that referenced this pull request Apr 4, 2026
Update eslint plugins (unicorn, sonarjs, jsdoc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant