Skip to content

Hide list wrappers containing only a hidden gateway field#3017

Merged
Crabcyborg merged 1 commit into
masterfrom
hide_list_wrappers_containing_only_a_hidden_gateway_field
Mar 13, 2026
Merged

Hide list wrappers containing only a hidden gateway field#3017
Crabcyborg merged 1 commit into
masterfrom
hide_list_wrappers_containing_only_a_hidden_gateway_field

Conversation

@Crabcyborg

@Crabcyborg Crabcyborg commented Mar 13, 2026

Copy link
Copy Markdown
Contributor

This was causing a pretty large gap as it would still show the margin and padding for the parent element.

Screen Shot 2026-03-13 at 3 07 06 PM

Summary by CodeRabbit

  • Refactor
    • Reorganized internal field visibility logic in the admin builder to improve code maintainability and structure.

@Crabcyborg Crabcyborg marked this pull request as ready for review March 13, 2026 18:07
@Crabcyborg Crabcyborg added this to the 6.30 milestone Mar 13, 2026
@coderabbitai

coderabbitai Bot commented Mar 13, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This change refactors inline CSS injection logic for hiding gateway fields in the admin builder from FrmAppController into a dedicated public static method in FrmTransLiteAppController, following the extract method pattern.

Changes

Cohort / File(s) Summary
CSS Field Visibility Refactoring
classes/controllers/FrmAppController.php, stripe/controllers/FrmTransLiteAppController.php
Relocated inline CSS injection that hides gateway-type fields in the builder UI from FrmAppController to a new public static method hide_gateway_fields_in_builder() in FrmTransLiteAppController, with conditional logic to exclude scenarios where the payments submodule is active.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A method born from refactored dreams,
Gateway fields now hidden by cleaner schemes,
From inline dust to controllers bright,
This extract-method makes the code just right! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main change: hiding list wrappers that contain only hidden gateway fields. This matches the PR's core objective of removing visible spacing from empty list wrappers.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch hide_list_wrappers_containing_only_a_hidden_gateway_field
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@deepsource-io

deepsource-io Bot commented Mar 13, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 2e73618...b115c5b on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
PHP Mar 13, 2026 6:07p.m. Review ↗
JavaScript Mar 13, 2026 6:07p.m. Review ↗

@Crabcyborg Crabcyborg merged commit 3804363 into master Mar 13, 2026
44 of 46 checks passed
@Crabcyborg Crabcyborg deleted the hide_list_wrappers_containing_only_a_hidden_gateway_field branch March 13, 2026 18:10
stephywells pushed a commit that referenced this pull request Apr 4, 2026
…g_only_a_hidden_gateway_field

Hide list wrappers containing only a hidden gateway field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant