fix broken actor link#43
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
This PR attempts to fix a broken actor_ref link in the bundled sap sample artifacts and hardens path validation for reading JSON artifacts in the sample Streamlit scenario planning app.
Changes:
- Updated
actor_reffields in multiplesample/data/scenarios/sap/**JSON artifacts. - Strengthened
_read_json_filepath-safety checks insample/app/scenario_planning.pyby switching fromstartswithchecks toresolve()+os.path.commonpath().
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| sample/data/scenarios/sap/traces/prior_snapshot.json | Updates sample trace actor_ref path. |
| sample/data/scenarios/sap/traces/planning_query.json | Updates sample trace actor_ref path. |
| sample/data/scenarios/sap/situation.json | Updates situation actor_ref (context + source_meta). |
| sample/data/scenarios/sap/generation/log.json | Updates generation log actor_ref path. |
| sample/app/scenario_planning.py | Improves safe path resolution / traversal prevention when reading JSON artifacts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -2,7 +2,7 @@ | |||
| "pack_id": "sap", | |||
| "pack_version": "1.0.0", | |||
| "situation_id": "sap_reltio_acquisition", | |||
| "actor_ref": "output/actors/sap_reltio_acquisition/actor_ontology.json", | |||
| "actor_ref": "data/actors/sap/actor_ontology.json", | |||
There was a problem hiding this comment.
actor_ref now points to data/actors/sap/actor_ontology.json, but this repo does not contain a data/actors/ directory (the bundled sample actor ontology lives under sample/data/actors/sap/actor_ontology.json). Update the reference to a path that actually exists for the sample bundle so the link resolves when loading the sample artifacts.
| "actor_ref": "data/actors/sap/actor_ontology.json", | |
| "actor_ref": "sample/data/actors/sap/actor_ontology.json", |
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "situation_id": "sap_reltio_acquisition", | |||
| "actor_ref": "output/actors/sap_reltio_acquisition/actor_ontology.json", | |||
| "actor_ref": "data/actors/sap/actor_ontology.json", | |||
There was a problem hiding this comment.
actor_ref now points to data/actors/sap/actor_ontology.json, but there is no data/actors/ directory in this repo; the sample actor ontology is under sample/data/actors/sap/actor_ontology.json. This reference will still be broken when resolving actor_ref from the bundled sample artifacts.
| "actor_ref": "data/actors/sap/actor_ontology.json", | |
| "actor_ref": "sample/data/actors/sap/actor_ontology.json", |
| @@ -28,7 +28,7 @@ | |||
| "How effectively Reltio's system will integrate data across SAP and non-SAP applications", | |||
| "Whether the acquisition will address the fundamental adoption barriers of BDC" | |||
| ], | |||
| "actor_ref": "output/actors/sap_reltio_acquisition/actor_ontology.json" | |||
| "actor_ref": "data/actors/sap/actor_ontology.json" | |||
There was a problem hiding this comment.
This actor_ref points to data/actors/sap/actor_ontology.json, but the bundled sample actor ontology is at sample/data/actors/sap/actor_ontology.json and data/actors/ does not exist in-repo. Use an in-repo path so the sample situation can be loaded without missing actor context.
| "actor_ref": "data/actors/sap/actor_ontology.json" | |
| "actor_ref": "sample/data/actors/sap/actor_ontology.json" |
| @@ -197,6 +197,6 @@ | |||
| "generated_at": "2026-04-12T12:23:29.498395", | |||
| "pack_id": "sap", | |||
| "pack_version": "1.0.0", | |||
| "actor_ref": "output/actors/sap_reltio_acquisition/actor_ontology.json" | |||
| "actor_ref": "data/actors/sap/actor_ontology.json" | |||
There was a problem hiding this comment.
source_meta.actor_ref now points to data/actors/sap/actor_ontology.json, but that path does not exist in this repo (sample actor ontology is under sample/data/actors/sap/actor_ontology.json). Keeping this consistent with the real file location avoids broken links in downstream viewers/loader utilities.
| "actor_ref": "data/actors/sap/actor_ontology.json" | |
| "actor_ref": "sample/data/actors/sap/actor_ontology.json" |
| @@ -71,7 +71,7 @@ | |||
| "scenario_planner": { | |||
| "actor_style_enhancement": { | |||
| "stage": "scenario_enhance_prompt", | |||
| "actor_ref": "output/actors/sap_reltio_acquisition/actor_ontology.json", | |||
| "actor_ref": "data/actors/sap/actor_ontology.json", | |||
There was a problem hiding this comment.
This trace log actor_ref points to data/actors/sap/actor_ontology.json, but data/actors/ is not present in this repo (sample actor ontology is under sample/data/actors/sap/actor_ontology.json). Update to an existing path so the trace can be followed from the bundled sample artifacts.
| "actor_ref": "data/actors/sap/actor_ontology.json", | |
| "actor_ref": "sample/data/actors/sap/actor_ontology.json", |
No description provided.