-
Notifications
You must be signed in to change notification settings - Fork 4
fix broken actor link #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -28,7 +28,7 @@ | |||||
| "How effectively Reltio's system will integrate data across SAP and non-SAP applications", | ||||||
| "Whether the acquisition will address the fundamental adoption barriers of BDC" | ||||||
| ], | ||||||
| "actor_ref": "output/actors/sap_reltio_acquisition/actor_ontology.json" | ||||||
| "actor_ref": "data/actors/sap/actor_ontology.json" | ||||||
|
||||||
| "actor_ref": "data/actors/sap/actor_ontology.json" | |
| "actor_ref": "sample/data/actors/sap/actor_ontology.json" |
Copilot
AI
Apr 13, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
source_meta.actor_ref now points to data/actors/sap/actor_ontology.json, but that path does not exist in this repo (sample actor ontology is under sample/data/actors/sap/actor_ontology.json). Keeping this consistent with the real file location avoids broken links in downstream viewers/loader utilities.
| "actor_ref": "data/actors/sap/actor_ontology.json" | |
| "actor_ref": "sample/data/actors/sap/actor_ontology.json" |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,6 +1,6 @@ | ||||||
| { | ||||||
| "situation_id": "sap_reltio_acquisition", | ||||||
| "actor_ref": "output/actors/sap_reltio_acquisition/actor_ontology.json", | ||||||
| "actor_ref": "data/actors/sap/actor_ontology.json", | ||||||
|
||||||
| "actor_ref": "data/actors/sap/actor_ontology.json", | |
| "actor_ref": "sample/data/actors/sap/actor_ontology.json", |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -2,7 +2,7 @@ | |||||
| "pack_id": "sap", | ||||||
| "pack_version": "1.0.0", | ||||||
| "situation_id": "sap_reltio_acquisition", | ||||||
| "actor_ref": "output/actors/sap_reltio_acquisition/actor_ontology.json", | ||||||
| "actor_ref": "data/actors/sap/actor_ontology.json", | ||||||
|
||||||
| "actor_ref": "data/actors/sap/actor_ontology.json", | |
| "actor_ref": "sample/data/actors/sap/actor_ontology.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This trace log
actor_refpoints todata/actors/sap/actor_ontology.json, butdata/actors/is not present in this repo (sample actor ontology is undersample/data/actors/sap/actor_ontology.json). Update to an existing path so the trace can be followed from the bundled sample artifacts.