[2515] fix configuration#1389
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the deployment packaging script to correctly apply runtime configuration into appsettings.json during packaging, aligning generated JSON structure with the application’s expected configuration shape.
Changes:
- Conditionally sets
Smtp.EnableSslfrom environment when provided. - Writes Serilog log level to
Serilog:MinimumLevel:Defaultinstead of overwritingMinimumLevel.
strongmindsnan
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KITOS Pull request template
Description
This pull request updates SMTP configuration handling to support authentication and SSL more robustly. The main changes add support for SMTP username and password in the
SingleThreadedMailClient, ensure these credentials are used when configuring the mail client, and improve the handling of theEnableSsland logging settings.SMTP Authentication and Configuration:
SingleThreadedMailClientconstructor to accept optionaluserNameandpasswordparameters and setSmtpClient.Credentialsif provided, enabling SMTP authentication.KitosServiceRegistration.csto readUserNameandPasswordfrom configuration and pass them to the mail client.Configuration and Deployment:
appsettings.jsondefault forSmtp:EnableSslto"true"to improve security.PreparePackage.ps1, now setsSerilog.MinimumLevel.Defaultinstead ofSerilog.MinimumLeveland ensuresSmtp.EnableSslis set from the environment if provided.Minor improvements:
using System.Net;inSingleThreadedMailClient.csto support credential assignment.Checklist
The following procedure dictates the steps needed before a Pull request can be merged into master.
Implement:
All requirements are implemented and unit tests are green
Merge master into branch / rebase with master:
Make sure you are testing your changes and how they co-exist with the latest version of master
Green on integration:
All integration tests are green on integration
Add a description
Under "Description" above, explain what was changed in this branch, and WHY it was changed
Request review:
Tag whomever you wish to review your code
Review completed:
Reviewer ticks this box when review comments have been submitted
Changes:
PR owner and reviewer agrees on which changes must be made and the changes are committed.
Merge master into branch / rebase with master:
Make sure you are testing your changes and how they co-exist with the latest version of master
Green on integration:
All integration tests are green on integration