Fix/org unit localid not unique index#1391
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts the EF Core model/migrations so OrganizationUnit (OrganizationId, LocalId) is indexed but no longer enforced as unique, aligning the database constraint with the intended domain behavior.
Changes:
- Replaced the unique filtered index on
(OrganizationId, LocalId)with a non-unique index (and renamedUX_LocalId→IX_LocalId). - Added an EF Core migration to drop/recreate the index accordingly.
- Updated the EF Core model snapshot to reflect the new index definition.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Infrastructure.DataAccess/Migrations/EfCore/KitosContextModelSnapshot.cs | Updates snapshot: (OrganizationId, LocalId) index is no longer unique/filtered and uses the new name. |
| Infrastructure.DataAccess/Migrations/EfCore/20260429070545_MakeOrganizationUnitLocalIdIndexNotUnique.cs | Migration drops UX_LocalId and creates IX_LocalId; Down migration restores the prior unique filtered index. |
| Infrastructure.DataAccess/Mapping/OrganizationUnitMap.cs | Updates fluent configuration to use a non-unique index named IX_LocalId. |
strongmindsaln
previously approved these changes
May 4, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
strongmindsaln
approved these changes
May 4, 2026
strongmindsmhs
approved these changes
May 4, 2026
strongmindsmhs
left a comment
strongmindsmhs
left a comment
There was a problem hiding this comment.
Please also consider Postgres naming conventions going forward:
https://www.geeksforgeeks.org/postgresql/postgresql-naming-conventions/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KITOS Pull request template
Description
Describe what was changed in this branch, and WHY it was changed.
Checklist
The following procedure dictates the steps needed before a Pull request can be merged into master.
Implement:
All requirements are implemented and unit tests are green
Merge master into branch / rebase with master:
Make sure you are testing your changes and how they co-exist with the latest version of master
Green on integration:
All integration tests are green on integration
Add a description
Under "Description" above, explain what was changed in this branch, and WHY it was changed
Request review:
Tag whomever you wish to review your code
Review completed:
Reviewer ticks this box when review comments have been submitted
Changes:
PR owner and reviewer agrees on which changes must be made and the changes are committed.
Merge master into branch / rebase with master:
Make sure you are testing your changes and how they co-exist with the latest version of master
Green on integration:
All integration tests are green on integration