Skip to content

[Bugfix] Minor bug fixes#1399

Merged
strongmindsaln merged 3 commits into
masterfrom
bugfix/minor-bug-fixes
May 11, 2026
Merged

[Bugfix] Minor bug fixes#1399
strongmindsaln merged 3 commits into
masterfrom
bugfix/minor-bug-fixes

Conversation

@strongmindsaln

@strongmindsaln strongmindsaln commented May 11, 2026

Copy link
Copy Markdown
Collaborator

KITOS Pull request template

Description

PR is responsible for following fixes:

  • Fixing OData filtering
  • Removing empty Internal swagger groups from production environments

Checklist

The following procedure dictates the steps needed before a Pull request can be merged into master.

  • Implement:
    All requirements are implemented and unit tests are green

  • Merge master into branch / rebase with master:
    Make sure you are testing your changes and how they co-exist with the latest version of master

  • Green on integration:
    All integration tests are green on integration

  • Add a description
    Under "Description" above, explain what was changed in this branch, and WHY it was changed

  • Request review:
    Tag whomever you wish to review your code

  • Review completed:
    Reviewer ticks this box when review comments have been submitted

  • Changes:
    PR owner and reviewer agrees on which changes must be made and the changes are committed.

  • Merge master into branch / rebase with master:
    Make sure you are testing your changes and how they co-exist with the latest version of master

  • Green on integration:
    All integration tests are green on integration

Copilot AI review requested due to automatic review settings May 11, 2026 04:59
@strongmindsaln
strongmindsaln marked this pull request as draft May 11, 2026 04:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR applies two small runtime bug fixes in the ASP.NET Web layer: cleaning up Swagger output after internal endpoints are removed, and hardening the custom OData contains binder to avoid null-related exceptions during in-memory query evaluation.

Changes:

  • Remove unused Swagger tag definitions after internal routes are stripped from the generated OpenAPI document.
  • Add a null-guard around the left-hand side of contains() when binding OData filters for case-insensitive matching.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
Presentation.Web/Swagger/RemoveInternalApiOperationsFilter.cs Adds post-processing to remove now-unused Swagger tag definitions after internal operations are removed.
Presentation.Web/Infrastructure/OData/CaseInsensitiveContainsFilterBinder.cs Wraps the contains() call with a null-check to prevent exceptions when filtering in-memory collections.

Comment thread Presentation.Web/Swagger/RemoveInternalApiOperationsFilter.cs
Comment thread Presentation.Web/Swagger/RemoveInternalApiOperationsFilter.cs
@strongmindsaln
strongmindsaln marked this pull request as ready for review May 11, 2026 05:29
@strongmindsaln
strongmindsaln merged commit 0841dae into master May 11, 2026
6 checks passed
@strongmindsaln
strongmindsaln deleted the bugfix/minor-bug-fixes branch May 11, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants