Skip to content

6071 rightsholder cvr in grid#1408

Merged
strongmindsnan merged 30 commits into
masterfrom
feature/kitosudv-6071-rightsholder-cvr-in-grid
May 21, 2026
Merged

6071 rightsholder cvr in grid#1408
strongmindsnan merged 30 commits into
masterfrom
feature/kitosudv-6071-rightsholder-cvr-in-grid

Conversation

@strongmindsnan

@strongmindsnan strongmindsnan commented May 19, 2026

Copy link
Copy Markdown

KITOS Pull request template

Description

Users wanted to be able to search for system rights holders and contract suppliers by CVR. This is now added to the name fields and their filters in the grid.

Checklist

The following procedure dictates the steps needed before a Pull request can be merged into master.

  • Implement:
    All requirements are implemented and unit tests are green

  • Merge master into branch / rebase with master:
    Make sure you are testing your changes and how they co-exist with the latest version of master

  • Green on integration:
    All integration tests are green on integration

  • Add a description
    Under "Description" above, explain what was changed in this branch, and WHY it was changed

  • Request review:
    Tag whomever you wish to review your code

  • Review completed:
    Reviewer ticks this box when review comments have been submitted

  • Changes:
    PR owner and reviewer agrees on which changes must be made and the changes are committed.

  • Merge master into branch / rebase with master:
    Make sure you are testing your changes and how they co-exist with the latest version of master

  • Green on integration:
    All integration tests are green on integration

Copilot AI review requested due to automatic review settings May 19, 2026 08:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the ItSystemUsageOverviewReadModel (used for system-usage grid/list read models) with the IT system rights holder’s CVR, and populates it during read model updates.

Changes:

  • Added a new ItSystemRightsholderCvr field to ItSystemUsageOverviewReadModel.
  • Patched ItSystemUsageOverviewReadModelUpdate to populate the new field from ItSystem.BelongsTo.
  • Extended the unit test to include CVR in the generated read model assertions.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
Tests.Unit.Core.ApplicationServices/DomainServices/SystemUsage/ItSystemUsageOverviewReadModelUpdateTest.cs Adds CVR to the test setup and asserts the new read model field is populated.
Core.DomainServices/SystemUsage/ItSystemUsageOverviewReadModelUpdate.cs Populates the new rights-holder CVR field when patching rights-holder data.
Core.DomainModel/ItSystemUsage/Read/ItSystemUsageOverviewReadModel.cs Introduces the new rights-holder CVR property on the persisted read model entity.

Comment thread Core.DomainModel/ItSystemUsage/Read/ItSystemUsageOverviewReadModel.cs Outdated
Comment thread Core.DomainServices/SystemUsage/ItSystemUsageOverviewReadModelUpdate.cs Outdated
@strongmindsnan
strongmindsnan marked this pull request as draft May 19, 2026 11:10
@strongmindsnan
strongmindsnan marked this pull request as ready for review May 19, 2026 18:04
strongmindsaln
strongmindsaln previously approved these changes May 20, 2026
@strongmindsnan
strongmindsnan merged commit ebc13c4 into master May 21, 2026
6 checks passed
@strongmindsnan
strongmindsnan deleted the feature/kitosudv-6071-rightsholder-cvr-in-grid branch May 21, 2026 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants