6071 rightsholder cvr in grid#1408
Merged
strongmindsnan merged 30 commits intoMay 21, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the ItSystemUsageOverviewReadModel (used for system-usage grid/list read models) with the IT system rights holder’s CVR, and populates it during read model updates.
Changes:
- Added a new
ItSystemRightsholderCvrfield toItSystemUsageOverviewReadModel. - Patched
ItSystemUsageOverviewReadModelUpdateto populate the new field fromItSystem.BelongsTo. - Extended the unit test to include CVR in the generated read model assertions.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| Tests.Unit.Core.ApplicationServices/DomainServices/SystemUsage/ItSystemUsageOverviewReadModelUpdateTest.cs | Adds CVR to the test setup and asserts the new read model field is populated. |
| Core.DomainServices/SystemUsage/ItSystemUsageOverviewReadModelUpdate.cs | Populates the new rights-holder CVR field when patching rights-holder data. |
| Core.DomainModel/ItSystemUsage/Read/ItSystemUsageOverviewReadModel.cs | Introduces the new rights-holder CVR property on the persisted read model entity. |
strongmindsnan
marked this pull request as draft
May 19, 2026 11:10
strongmindsnan
marked this pull request as ready for review
May 19, 2026 18:04
strongmindsaln
previously approved these changes
May 20, 2026
strongmindsaln
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KITOS Pull request template
Description
Users wanted to be able to search for system rights holders and contract suppliers by CVR. This is now added to the name fields and their filters in the grid.
Checklist
The following procedure dictates the steps needed before a Pull request can be merged into master.
Implement:
All requirements are implemented and unit tests are green
Merge master into branch / rebase with master:
Make sure you are testing your changes and how they co-exist with the latest version of master
Green on integration:
All integration tests are green on integration
Add a description
Under "Description" above, explain what was changed in this branch, and WHY it was changed
Request review:
Tag whomever you wish to review your code
Review completed:
Reviewer ticks this box when review comments have been submitted
Changes:
PR owner and reviewer agrees on which changes must be made and the changes are committed.
Merge master into branch / rebase with master:
Make sure you are testing your changes and how they co-exist with the latest version of master
Green on integration:
All integration tests are green on integration