Fix /pack upload path (Storage::path, local disk root is app/private)#32
Merged
Conversation
…app/private) The worker looked for the archive at storage/app/packs/... but storeAs put it at storage/app/private/packs/... (Laravel's local disk root), so unpack failed with 'Could not read the pack archive listing'. Use Storage::path($stored) so the path matches wherever the disk actually wrote it.
A 10-min take at 1fps = ~650 sequential OCR calls (~20min) + thousands of noisy spans. Cap total frames (default 250): keep every interaction, widen the baseline cadence to fit the remaining budget. Short takes are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The worker looked for the uploaded archive at storage/app/packs/... but storeAs writes to storage/app/private/packs/... (Laravel's local disk root). Resolve via Storage::path($stored). Confirmed end-to-end on Netcup: a real pack now produces crunch.json (transcript + event join + moments).