Fix tag chips unreadable in Light theme#45
Merged
Conversation
Tag chips on snip cards (and the parameter-type badge in Shared parameters) set an accent background but no foreground, so the text fell back to the theme default — dark in Light theme, leaving dark text on the accent fill. Set the on-accent text brush so it stays light and readable in both themes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Tag chips on snip cards showed dark text on the blue accent fill in Light theme, making them hard to read. Dark theme looked fine.
Cause
The chip
BordersetsBackground="{ThemeResource AccentFillColorSecondaryBrush}"but theTextBlockhad no explicitForeground, so it fell back to the theme's default text colour — dark in Light theme (dark-on-accent), light in Dark theme (which is why dark looked OK).Fix
Set
Foreground="{ThemeResource TextOnAccentFillColorPrimaryBrush}"on the chip text — the same on-accent brush accent buttons use — so it stays light and readable on the accent fill in both themes.Applied to both accent chips:
SnipCard.xaml).Text/Choice) in the Shared parameters list (ShellPage.xaml), which had the identical issue.Testing
🤖 Generated with Claude Code