Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
edits survive app updates. Delete it to restore the default set.

### Fixed
- **Tag chips unreadable in Light theme.** Tag chips on snip cards (and the
parameter-type badge in Shared parameters) showed dark text on the accent fill in
Light theme. They now use the on-accent text colour, readable in both themes.
- **Window caption buttons invisible in Light theme.** The minimise, maximise and
close glyphs were always white, leaving them barely visible against the light
title bar. They now take a theme-appropriate colour, update when you switch
Expand Down
6 changes: 5 additions & 1 deletion src/Snipdeck.App/Controls/SnipCard.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,12 @@
<Border Background="{ThemeResource AccentFillColorSecondaryBrush}"
CornerRadius="10"
Padding="8,2">
<!-- Explicit on-accent foreground: without it the text falls
back to the theme's default (dark in Light theme), which
is unreadable on the accent fill. -->
<TextBlock Text="{x:Bind}"
Style="{ThemeResource CaptionTextBlockStyle}" />
Style="{ThemeResource CaptionTextBlockStyle}"
Foreground="{ThemeResource TextOnAccentFillColorPrimaryBrush}" />
</Border>
</DataTemplate>
</ItemsControl.ItemTemplate>
Expand Down
3 changes: 2 additions & 1 deletion src/Snipdeck.App/Views/ShellPage.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,8 @@
Padding="8,2"
VerticalAlignment="Center">
<TextBlock Text="{x:Bind TypeDisplay}"
Style="{ThemeResource CaptionTextBlockStyle}" />
Style="{ThemeResource CaptionTextBlockStyle}"
Foreground="{ThemeResource TextOnAccentFillColorPrimaryBrush}" />
</Border>
</Grid>
<TextBlock Style="{ThemeResource CaptionTextBlockStyle}"
Expand Down
Loading