Skip to content

fix(auth): show OAuth callback errors - #191

Open
AyobamiH wants to merge 1 commit into
StudentSuite:mainfrom
AyobamiH:fix/162-login-auth-error
Open

fix(auth): show OAuth callback errors#191
AyobamiH wants to merge 1 commit into
StudentSuite:mainfrom
AyobamiH:fix/162-login-auth-error

Conversation

@AyobamiH

@AyobamiH AyobamiH commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Show a dismissible alert when the OAuth callback returns an error
  • Map the known auth_error code to clear, user-friendly copy
  • Use a Map so every unknown URL value, including prototype property names such as proto, safely falls back to generic copy
  • Add focused tests for rendering, dismissal, adversarial unknown-code handling, and the no-error state
  • Give the dismiss control a 24px pointer target

Fixes #162.

Verification

  • npx vitest run src/app/login/login-form.test.tsx (3 passed)
  • npm run test:unit (131 passed)
  • npm run lint
  • npx tsc --noEmit
  • npm run build
  • git diff --check
  • npm run dev reached ready successfully

The visible alert and dismissal behaviour are covered by the repository’s jsdom component tests.

@vercel

vercel Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

@AyobamiH is attempting to deploy a commit to the studentsuite Team on Vercel.

A member of the Team first needs to authorize it.

@AyobamiH
AyobamiH force-pushed the fix/162-login-auth-error branch from f424cf3 to e0a4bdb Compare September 4, 2026 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: /login?error=auth_error is produced by the callback but never shown by the login form

1 participant