feat(round): implement paginated bidder reads end-to-end - #12
Merged
karagozemin merged 1 commit intoJun 23, 2026
Merged
Conversation
Adds BiddersPage struct, get_bidders_page contract function (cursor+limit), TypeScript bindings, SDK pagination support (getBiddersPage + async generator), and keeper migration from bulk getBidders to paginated iteration. Closes Sub-Rosa-Issue#7
|
@NnamdiCyber Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
9 tasks
VeronicDev
pushed a commit
to VeronicDev/sub-rosa-drips
that referenced
this pull request
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The existing
get_biddersview returns the entire bidder index as one array. For rounds with hundreds or thousands of bidders, this forces the keeper to load all addresses into memory at once and risks hitting Soroban RPC response size limits.Solution
Add
get_bidders_page— a zero-based cursor/limit paginated view — across all layers, keeping the originalget_biddersfully intact for backward compatibility.Contract (
contracts/round/)