expand client configuration validation coverage by emirykl · Pull Request #23 · Sub-Rosa-Issue/sub-rosa-issue

emirykl · 2026-06-24T22:53:00Z

Summary

add focused tests for SubRosaClient configuration behavior
return SubRosaClientConfigError for unsafe HTTP RPC URLs unless allowHttp is enabled
cover confirmTimeout and pollInterval boundaries and non-finite values
verify missing operator and bidder source failures use typed errors
verify external submitter options and SubRosaSubmitError cause wrapping
keep all tests deterministic without live RPC or wall-clock sleeps

Closes #19

drips-wave · 2026-06-24T22:53:07Z

@emirykl Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

…-Issue#8, Sub-Rosa-Issue#23) Merge PR Sub-Rosa-Issue#23 with conflict fix in ethereum-listener (async order path from Sub-Rosa-Issue#19 + listenerLastBlock metrics). Closes Sub-Rosa-Issue#8. Co-authored-by: Windowlight <abioladonald757@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>

expand client configuration validation coverage

79eea7d

karagozemin merged commit fee6ea0 into Sub-Rosa-Issue:main Jun 26, 2026