Skip to content

Add bounded retry policy for transient Drand and Soroban keeper opera… - #24

Closed
Anieblin wants to merge 1 commit into
Sub-Rosa-Issue:mainfrom
Anieblin:feature/bounded-retry-keeper
Closed

Add bounded retry policy for transient Drand and Soroban keeper opera…#24
Anieblin wants to merge 1 commit into
Sub-Rosa-Issue:mainfrom
Anieblin:feature/bounded-retry-keeper

Conversation

@Anieblin

@Anieblin Anieblin commented Jun 24, 2026

Copy link
Copy Markdown

Closes #4


…tions

@drips-wave

drips-wave Bot commented Jun 24, 2026

Copy link
Copy Markdown

@Anieblin Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@karagozemin

Copy link
Copy Markdown
Collaborator

Thanks for the PR. I tested the current head (7397ac0) in a clean merge simulation against current main.

Commands run:

  • pnpm tlock:test
  • pnpm keeper:test
  • pnpm --filter @sub-rosa/tlock typecheck
  • pnpm --filter @sub-rosa/keeper typecheck

This cannot be merged yet because the keeper package is currently broken after the merge.

Observed failures:

  • keeper tests fail at runtime because @sub-rosa/tlock does not export fetchRoundSignatureWithRetry.
  • keeper typecheck also reports missing exports for fetchRoundSignatureWithRetry, withRetry, retryPolicyFromEnv, RetryPolicy, and defaultRetryPolicy.
  • keeper.ts also has implicit any logger parameters after the failed imports.

Additional acceptance gaps to fix while updating:

  • packages/tlock/src/retry.test.ts is not wired into the @sub-rosa/tlock test script, so pnpm tlock:test does not run the new retry tests.
  • Watch-mode retry environment configuration should be documented outside source comments, for example in .env.example and/or docs/DEPLOY.md.
  • Please add a real keeper test for retrying transient Drand fetch failures. The current Drand retry test only asserts policy shape; it does not exercise keepRound or Drand retry behavior.

After those are fixed, please make sure these pass deterministically:

  • pnpm tlock:test
  • pnpm keeper:test
  • pnpm --filter @sub-rosa/tlock typecheck
  • pnpm --filter @sub-rosa/keeper typecheck

VeronicDev pushed a commit to VeronicDev/sub-rosa-drips that referenced this pull request Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add bounded retry and backoff policies to keeper RPC and Drand operations

3 participants