Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5d0772be7c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| args.imageTag || (args.releaseTag ? `${args.imageRepository || DEFAULT_IMAGE_REPOSITORY}:${args.releaseTag}` : ""); | ||
|
|
||
| if (releaseAssetBaseUrl) { | ||
| inferred.installerReleaseUrl = inferred.installerReleaseUrl || urlJoin(releaseAssetBaseUrl, "release.json"); |
There was a problem hiding this comment.
When the generated installer is downloaded through the normal releases/latest/download/install.sh path, this pins DEFAULT_RELEASE_URL to the concrete release tag, and local/scripts/install.sh later persists that same value into .env as SUBBOOST_RELEASE_URL; local/scripts/subboost.sh:update_cmd then fetches only that saved URL for future updates. As a result, stable installs created from the latest installer keep re-reading the original tag's release.json and subboost update cannot advance them to newer stable releases without manual env edits. Consider keeping the persisted release URL on the latest channel while pinning the fallback asset/image defaults separately.
Useful? React with 👍 / 👎.
| const releaseImageTag = | ||
| args.imageTag || (args.releaseTag ? `${args.imageRepository || DEFAULT_IMAGE_REPOSITORY}:${args.releaseTag}` : ""); |
There was a problem hiding this comment.
For release builds that pass an exact --image value but omit --image-tag, buildManifest() writes that exact image to release.json, while this inference builds DEFAULT_IMAGE from the repository/tag fallback instead. If the installer cannot fetch release.json and has to use DEFAULT_IMAGE, it can install ghcr.io/subboost/subboost:<tag> rather than the image actually published for that release. Derive the fallback from args.image || args.imageTag || ..., or require --image-tag whenever --image is supplied.
Useful? React with 👍 / 👎.
1 participant
Summary\n- infer installer asset URLs from the release asset base URL\n- pin stable release install.sh defaults to the same release tag and image tag\n\n## Validation\n- npx vitest run service/test/scripts/selfhost-oneclick.test.ts\n- git diff --check