feat: proxy-providers import mode for URL sources#56
Conversation
- Per-source provider settings: custom key, attach mode (grouped/inline/bare), emoji group name, node filter regex; persisted end-to-end (store, handoff, subscription save/load, server-side saved-sources normalization) - Grouped mode generates an airport group (select + use) that joins all manual-select groups as a regular member: excludable, sortable, and manually attachable to any group via new provider member refs - Fixed provider defaults (interval, health-check), provider path follows key - UI: inline status bar on URL source editors, provider settings in advanced dialog, read-only airport group card, provider members in group editor, airport groups in visual preview
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 73830ab590
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const autoIndex = autoTarget ? proxies.indexOf(autoTarget) : -1; | ||
| const selectIndex = selectTarget ? proxies.indexOf(selectTarget) : -1; | ||
| const anchorIndex = autoIndex >= 0 ? autoIndex : selectIndex; | ||
| const insertAt = anchorIndex >= 0 ? anchorIndex + 1 : 0; | ||
| return [...proxies.slice(0, insertAt), ...missing, ...proxies.slice(insertAt)]; |
There was a problem hiding this comment.
When the config has only URL sources in grouped proxy-provider mode (the UI now sets this mode by default when enabling providers), there are no parsed nodes and ⚡ 自动选择 is generated with no proxies/use because grouped providers are excluded from the inline provider list. Inserting the airport group after autoTarget leaves 🚀 节点选择 defaulting to that empty auto group, so provider-only subscriptions start on a dead/invalid policy until the user manually switches to the airport group.
Useful? React with 👍 / 👎.
| const groupedAttachments = groupedProviderKeys | ||
| .map((key) => attachmentByKey.get(key)) | ||
| .filter((attachment): attachment is ProxyProviderAttachment => Boolean(attachment)); |
There was a problem hiding this comment.
When two grouped sources use the same providerGroupName and their provider keys sort differently from source order, this sorted provider-key list changes which key receives the unsuffixed/suffixed airport-group name compared with the UI/provider preview, which builds from source order. Since the advanced editor stores exclusions and ordering as provider-group keys, excluding the UI's “Air” can remove “Air 2” in the generated YAML.
Useful? React with 👍 / 👎.
| type="button" | ||
| role="radio" | ||
| aria-checked={mode === option.value} | ||
| onClick={() => onUpdateMeta(source.id, { providerMode: option.value })} |
There was a problem hiding this comment.
Changing this radio only calls onUpdateMeta with providerMode; in the controller that flows through setSources, which does not recompute generatedYaml when no source is removed, and these new provider fields are not part of the reimport snapshot. For an already-imported provider source, switching grouped/inline/bare (or editing key/filter/group name) leaves preview/download using the previous proxy-provider wiring until some unrelated generation-triggering action runs.
Useful? React with 👍 / 👎.
| const key = source.providerKey?.trim() || `url_${source.id}`; | ||
| out.push({ ref: { kind: "provider-inline", key }, label: `内联 ${key}` }); |
There was a problem hiding this comment.
When a saved/imported source id contains characters that the provider builder sanitizes (for example bad/url becomes url_bad_url), this chip stores provider-inline:url_bad/url instead of the actual provider key. The generator only accepts keys present in the provider plan, so clicking the chip appears to add that bare/grouped provider to a policy group but no use: entry is emitted.
Useful? React with 👍 / 👎.
2 participants
What
Adds an optional proxy-providers import mode for URL subscription sources: instead of fetching and inlining nodes, a source can be emitted as a mihomo
proxy-providersentry, letting mihomo itself fetch and refresh the subscription.为 URL 订阅源增加可选的 proxy-providers 导入模式：不再拉取节点内联，而是把订阅输出为 mihomo
proxy-providers条目，由 mihomo 自行拉取与更新。Features / 功能
grouped（分组，默认）: generates an "airport group"{name, type: select, use: [key]}. The group joins all manual-select policy groups and custom groups as a regular member — it can be excluded, reordered, and manually attached to any group in the advanced group editor.inline（内嵌）: provider key is injected viause:into all policy groups (legacy behavior; default for old saved data).bare（仅生成）: only writesproxy-providers, attaches nothing.interval: 43200, health-checkinterval: 300 / timeout: 5000 / lazy: true;pathfollows the provider key (sanitized, deduped); default node filter regex excludes info nodes (customizable per source, empty string = no filter).mihomo reference
proxy-providersfields anduse:semantics per https://wiki.metacubex.one/config/proxy-providers/ andconfig/proxy-groups/.Tests
--max-warnings=0clean.