Skip to content

1.12.2

  • 1.12.2
  • c18f8d0

  • Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    GPG key ID: B5690EEEBB952194
    Verified
    Learn about vigilant mode

  • Choose a tag to compare

    View all tags
1.12.2: Read and print tests output as UTF-8 in run_tests.py (#303)
  • 1.12.2
  • c18f8d0

  • Choose a tag to compare

    View all tags

  • Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    GPG key ID: B5690EEEBB952194
    Verified
    Learn about vigilant mode
@rchl rchl tagged this 20 Oct 06:43 
The tests output is written as UTF-8, but run_tests.py read it with the
locale's encoding. On Windows (cp1252) a non-ASCII character crashed the
reader thread with a UnicodeDecodeError, and the run ended with "Timeout:
output is frozen." instead of the test results.

- Open all files as UTF-8, matching how UnitTesting writes them.
- Reconfigure stdout to UTF-8, since it uses cp1252 when piped on Windows
  and printing the output would fail next.
- Make the reader thread a daemon, so that an error in the main thread
  doesn't leave the process hanging.
Assets 2
Loading