feat: remove deprecated input output values#509
Merged
Conversation
sergebouchut2
changed the base branch from
main
to
feat/input_output_assets_new_endpoints
sergebouchut2
changed the title
sergebouchut2
force-pushed
the
feat/remove_deprecated_input_output_values
branch
from
31c3af7 to
0e9943a
Compare
2 tasks
Base automatically changed from
feat/input_output_assets_new_endpoints
to
main
October 3, 2022 15:50
sergebouchut2
force-pushed
the
feat/remove_deprecated_input_output_values
branch
from
0e9943a to
6dfea38
Compare
sergebouchut2
changed the title
sergebouchut2
force-pushed
the
feat/remove_deprecated_input_output_values
branch
from
6dfea38 to
6470fe5
Compare
sergebouchut2
requested review from
AlexandrePicosson,
AurelienGasser,
Kelvin-M,
cboillet-dev,
mblottiere and
samlesu
as code owners
sergebouchut2
force-pushed
the
feat/remove_deprecated_input_output_values
branch
from
6470fe5 to
2390c9e
Compare
cboillet-dev
approved these changes
Oct 7, 2022
Contributor
|
/e2e --tests=substrafl,sdk --benchmarks=mnist,camelyon |
|
End to end tests: ❌ FAILURE It'll stay between us, no one needs to know. |
guilhem-barthes
force-pushed
the
feat/remove_deprecated_input_output_values
branch
from
2390c9e to
9c6e6d4
Compare
guilhem-barthes
requested review from
Milouu,
ThibaultFy,
guilhem-barthes and
oleobal
as code owners
Contributor
|
/e2e --tests=substrafl,sdk --benchmarks=mnist,camelyon |
ThibaultFy
removed request for
AlexandrePicosson,
acellard,
mblottiere and
samlesu
guilhem-barthes
force-pushed
the
feat/remove_deprecated_input_output_values
branch
from
9c6e6d4 to
b014039
Compare
oleobal
approved these changes
Feb 8, 2023
Contributor
oleobal
left a comment
oleobal
left a comment
There was a problem hiding this comment.
Do we need to wait until 0.26 is out before merging?
7 tasks
guilhem-barthes
force-pushed
the
feat/remove_deprecated_input_output_values
branch
from
b014039 to
50c4026
Compare
SdgJlbl
reviewed
May 30, 2023
SdgJlbl
approved these changes
May 30, 2023
Contributor
SdgJlbl
left a comment
SdgJlbl
left a comment
There was a problem hiding this comment.
Thanks for finally bringing this saga to a happy ending :)
4 tasks
Signed-off-by: Serge Bouchut <serge.bouchut@owkin.com>
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
guilhem-barthes
force-pushed
the
feat/remove_deprecated_input_output_values
branch
from
ff2a765 to
cfd3a9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Description
Following #496, removing deprecated field.
Fixes FL-568
How has this been tested?
Checklist