Skip to content

feat: use new substra functions#256

Merged
guilhem-barthes merged 14 commits into
mainfrom
chore/remove-output.value-from-tests
Jun 5, 2023
Merged

feat: use new substra functions#256
guilhem-barthes merged 14 commits into
mainfrom
chore/remove-output.value-from-tests

Conversation

@guilhem-barthes
Copy link
Copy Markdown
Contributor

@guilhem-barthes guilhem-barthes commented May 19, 2023

Related issue

Summary

Adapt tests to:

  • remove usage of .value in task outputs
  • use new functions to get input/output assets.

Fixes FL-652

Test

Ci in substra companion PR

Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
@guilhem-barthes guilhem-barthes force-pushed the chore/remove-output.value-from-tests branch from 41858a7 to 7409255 Compare June 1, 2023 15:34
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
@guilhem-barthes guilhem-barthes marked this pull request as ready for review June 2, 2023 10:22
@guilhem-barthes guilhem-barthes requested a review from a team as a code owner June 2, 2023 10:22
@linear
Copy link
Copy Markdown

linear Bot commented Jun 2, 2023

FL-652 Implement refactoring input/output in tasks

Context and user need:

The SDK uses some deprecated features (namely, using value to download model in remote mode). Once we defined how to replace them, we will implement these changes.

Functional spec:

Technical spec:
TBD after discussions.

Acceptance criteria:
Being able to remove value in the backend and not breaking the remote mode in sdk

Comment thread tests/test_execution.py Outdated
Comment thread tests/test_execution_compute_plan.py
Copy link
Copy Markdown
Member

@ThibaultFy ThibaultFy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !! First review :)

Comment thread tests/test_execution.py Outdated
Comment thread tests/test_execution_compute_plan.py Outdated
Comment thread tests/test_execution_compute_plan.py Outdated
Comment thread tests/test_hybrid_mode.py Outdated
Comment thread tests/test_permissions.py Outdated
Comment thread tests/workflows/mnist-fedavg/test_workflow.py Outdated
Comment thread tests/workflows/mnist-fedavg/test_workflow.py Outdated
Comment thread tests/workflows/mnist-fedavg/test_workflow.py Outdated
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Comment thread tests/test_execution.py Outdated
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
@guilhem-barthes guilhem-barthes requested a review from SdgJlbl June 5, 2023 15:24
guilhem-barthes added a commit to Substra/substra-backend that referenced this pull request Jun 5, 2023
## Related issues

- Substra/substra-tests#256
- Substra/substra#361
- Substra/substrafl#129


## Description

:warning: **DO NOT MERGE** until the frontend is switched to the new
endpoints.

Following #496, removing deprecated field.
- input: addressable, permissions
- output: values

Fixes FL-568

## How has this been tested?

<!-- Please describe the tests that you ran to verify your changes.  -->

## Checklist

- [x] [changelog](../CHANGELOG.md) was updated with notable changes
- [ ] documentation was updated


---
- To see the specific tasks where the Asana app for GitHub is being
used, see below:
  - https://app.asana.com/0/0/1203097915891016

---------

Signed-off-by: Serge Bouchut <serge.bouchut@owkin.com>
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Co-authored-by: Guilhem Barthes <guilhem.barthes@owkin.com>
@guilhem-barthes guilhem-barthes merged commit 2d46b9e into main Jun 5, 2023
@guilhem-barthes guilhem-barthes deleted the chore/remove-output.value-from-tests branch June 5, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants