feat: remove failed task category from compute plan API response#525
Merged
Conversation
Contributor
Author
|
/e2e --refs substra=feat/remove_failed_task_category,substra-backend=feat/remove_failed_task_category --tests sdk,substrafl |
|
End to end tests: ✔️ SUCCESS “To infinity and beyond!” ― Buzz Lightyear, Toy Story |
This was referenced Oct 7, 2022
2 tasks
03f698b to
8435791
Compare
Member
|
/e2e --refs substra=feat/remove_failed_task_category,substra-backend=feat/remove_failed_task_category --tests sdk,substrafl |
|
End to end tests: ✔️ SUCCESS |
ThibaultFy
reviewed
Jan 17, 2023
Member
ThibaultFy
left a comment
There was a problem hiding this comment.
@guilhem-barthes shouldn't we also remove failed_task_category from the ComputePlan model ?
Member
|
/e2e --help |
|
dc34d97 to
488a2e6
Compare
Signed-off-by: Serge Bouchut <serge.bouchut@owkin.com>
Signed-off-by: Milouu <milan.roustan@owkin.com>
488a2e6 to
1e3d5f0
Compare
Signed-off-by: Milouu <milan.roustan@owkin.com>
a355e70 to
01c4607
Compare
Signed-off-by: Milouu <milan.roustan@owkin.com>
guilhem-barthes
approved these changes
Jan 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Signed-off-by: Serge Bouchut serge.bouchut@owkin.com
Description
Remove failed task category deprecated field from the compute plan API response in order to easily remove category field in the backend later.
See also:
How has this been tested?
Checklist