Skip to content

feat: remove failed task category#309

Merged
ThibaultFy merged 3 commits into
mainfrom
feat/remove_failed_task_category
Mar 23, 2023
Merged

feat: remove failed task category#309
ThibaultFy merged 3 commits into
mainfrom
feat/remove_failed_task_category

Conversation

@sergebouchut2
Copy link
Copy Markdown
Contributor

@sergebouchut2 sergebouchut2 commented Oct 7, 2022

Signed-off-by: Serge Bouchut serge.bouchut@owkin.com

Related issue

# followed by the number of the issue

Summary

Remove failed task category deprecated field.
See: Substra/substra-backend#525

Notes

Please check if the PR fulfills these requirements

  • If necessary, the changelog has been updated
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • The commit message follows the conventional commit specification
  • For any breaking changes, companion PRs have been opened on the following repositories:

Copy link
Copy Markdown
Contributor

@guilhem-barthes guilhem-barthes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
@ThibaultFy ThibaultFy force-pushed the feat/remove_failed_task_category branch from 1bec734 to ea409b0 Compare March 23, 2023 15:19
@ThibaultFy ThibaultFy requested a review from a team as a code owner March 23, 2023 15:19
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
@ThibaultFy
Copy link
Copy Markdown
Member

/e2e

@Owlfred
Copy link
Copy Markdown

Owlfred commented Mar 23, 2023

End to end tests: ✔️ SUCCESS

@ThibaultFy ThibaultFy merged commit 97d4e17 into main Mar 23, 2023
@ThibaultFy ThibaultFy deleted the feat/remove_failed_task_category branch March 23, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants