Skip to content

fix: amend end-to-end tests to work with the new API (cf substra-back…#248

Merged
guilhem-barthes merged 1 commit into
mainfrom
fix/compute-task-performance-issue
Mar 24, 2023
Merged

fix: amend end-to-end tests to work with the new API (cf substra-back…#248
guilhem-barthes merged 1 commit into
mainfrom
fix/compute-task-performance-issue

Conversation

@SdgJlbl
Copy link
Copy Markdown
Contributor

@SdgJlbl SdgJlbl commented Mar 21, 2023

…end#613)

Main PR Substra/substra-backend#613
Passing end-to-end Substra/substra-backend#613 (comment)

Related PR in substra Substra/substra#350

Local tests pass on my local dev env (Python 3.9).

@SdgJlbl SdgJlbl requested a review from a team as a code owner March 21, 2023 17:27
@SdgJlbl SdgJlbl force-pushed the fix/compute-task-performance-issue branch from d129eca to 0f3d3ea Compare March 22, 2023 09:49
@ThibaultFy
Copy link
Copy Markdown
Member

Please put the link of the companion PRs in the summary, and indicate which one in the "main" where e2e tests are launched with the bot

for (perf, testtask) in zip(expected_perf, testtasks)
]
)
assert all(perf_dict[testtask.key] == pytest.approx(perf) for (perf, testtask) in zip(expected_perf, testtasks))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

Copy link
Copy Markdown
Contributor

@guilhem-barthes guilhem-barthes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

…end#613)

Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
@SdgJlbl SdgJlbl force-pushed the fix/compute-task-performance-issue branch from 0f3d3ea to 4e5aa3f Compare March 24, 2023 11:03
@guilhem-barthes guilhem-barthes merged commit dc2234e into main Mar 24, 2023
@guilhem-barthes guilhem-barthes deleted the fix/compute-task-performance-issue branch March 24, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants