Skip to content

chore: unskip tests #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SdgJlbl merged 1 commit into from
Feb 12, 2024
Merged

chore: unskip tests #315

SdgJlbl merged 1 commit into from
Feb 12, 2024

Conversation

@SdgJlbl
Copy link
Contributor

@SdgJlbl SdgJlbl commented Feb 8, 2024 •
edited
Loading

Still to unskip

  • tests/test_execution.py::test_function_build_failure (waiting for fix in backend)
  • tests/test_execution.py::test_aggregatetask (race condition)

@SdgJlbl
chore: unskip tests
87650ef 
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
@SdgJlbl
Copy link
Contributor Author

SdgJlbl commented Feb 8, 2024

/e2e --tests sdk

@Owlfred
Copy link

Owlfred commented Feb 8, 2024 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

That's a shame.

@SdgJlbl
Copy link
Contributor Author

SdgJlbl commented Feb 8, 2024

⬆️ only one unskipped test failed, to be fixed with #807

@SdgJlbl
Copy link
Contributor Author

SdgJlbl commented Feb 12, 2024

/e2e --tests sdk

@Owlfred
Copy link

Owlfred commented Feb 12, 2024 •
edited
Loading

End to end tests: ✔️ SUCCESS

Awesome! 🎉

@SdgJlbl SdgJlbl marked this pull request as ready for review February 12, 2024 10:54
@SdgJlbl SdgJlbl requested a review from a team as a code owner February 12, 2024 10:54
thbcmlowk
thbcmlowk approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@thbcmlowk thbcmlowk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@SdgJlbl SdgJlbl merged commit 6719b42 into main Feb 12, 2024
@SdgJlbl SdgJlbl deleted the chore/unskip-tests branch February 12, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thbcmlowk thbcmlowk thbcmlowk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SdgJlbl @Owlfred @thbcmlowk