-
Notifications
You must be signed in to change notification settings - Fork 0
fix: prevent app crash on missing Supabase env vars #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Sujal1201
wants to merge
1
commit into
main
Choose a base branch
from
fix/supabase-env-vars-2223790483192614043
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,11 @@ | ||
| import { createClient } from '@supabase/supabase-js'; | ||
| import type { Database } from './database.types'; | ||
|
|
||
| const supabaseUrl = import.meta.env.VITE_SUPABASE_URL; | ||
| const supabaseAnonKey = import.meta.env.VITE_SUPABASE_ANON_KEY; | ||
| const supabaseUrl = import.meta.env.VITE_SUPABASE_URL || 'https://placeholder.supabase.co'; | ||
| const supabaseAnonKey = import.meta.env.VITE_SUPABASE_ANON_KEY || 'placeholder'; | ||
|
|
||
| if (!supabaseUrl || !supabaseAnonKey) { | ||
| throw new Error('Missing Supabase environment variables'); | ||
| if (!import.meta.env.VITE_SUPABASE_URL || !import.meta.env.VITE_SUPABASE_ANON_KEY) { | ||
| console.warn('Missing Supabase environment variables. Using placeholder values.'); | ||
| } | ||
|
|
||
| export const supabase = createClient<Database>(supabaseUrl, supabaseAnonKey); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using hard-coded placeholder values means the app will still create a Supabase client and attempt real network calls (e.g., in App.tsx on startup) against
https://placeholder.supabase.cowith a bogus key. This can cause confusing runtime failures, slow startup, and can unintentionally send requests to an external domain when the app is misconfigured. Safer pattern: only create/export a real client when both env vars are present; otherwise exportnull/undefined(or a stub that throws on use) plus anisSupabaseConfiguredflag so callers can skip data loading and show a configuration error screen.