Add "timestamp_key", prefer log message when merging #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timestamp_keyproperty, which allows the user to customize the default key oftimestamp(+ tests)json_mergeso that the log message wins over the record data in cases of conflict (+ tests)Notes
{ :timestamp => 123 }) to a string{ 'timestamp' => 123 }is important.JSON.dump({ :foo => 'bar', 'foo' => 'qux' })will return{"foo:"bar","foo":"qux"}so we need key types to match.Motivation
Scoop uses a standard logging library across our apps that emits newline-delimited JSON. It includes timestamps as
{"time": 123}. A dev noticed that log lines from Kubernetes contained bothtimestampandtime. Because we usejson_merge, both properties appear at the same level. We'd like to configure fluentd to render a timestamp astimeto any log line missing it (including non-JSON) but not overwrite an existingtimeproperty in JSON lines.