Skip to content

add support for node10/12 in kinesis handler #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2020
Merged

add support for node10/12 in kinesis handler #113

merged 1 commit into from
May 5, 2020

Conversation

@pwmcintyre
Copy link
Contributor

@pwmcintyre pwmcintyre commented Apr 2, 2020 •
edited
Loading

this is an additional fix for #108 using the same regex as the previously accepted PR #110

@pwmcintyre
Copy link
Contributor Author

pwmcintyre commented Apr 2, 2020

build is failing for unrelated reasons:

======================================================================
ERROR: test_lambda (__main__.TestLambda)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_cwl_lambda.py", line 32, in setUp
    raise Exception("SumoEndPointURL environment variables are not set")
Exception: SumoEndPointURL environment variables are not set

himanshu219
himanshu219 approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@himanshu219 himanshu219 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@himanshu219 himanshu219 merged commit 469c015 into SumoLogic:master May 5, 2020
@pwmcintyre pwmcintyre deleted the patch-1 branch May 22, 2020 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@himanshu219 himanshu219 himanshu219 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pwmcintyre @himanshu219