SUMO-136652: Added delay in subscribing existing log groups #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SumoSourabh
approved these changes
May 15, 2020
Contributor
SumoSourabh
left a comment
SumoSourabh
left a comment
There was a problem hiding this comment.
Put in one concern for timeout. Other than that LGTM
| if (logGroupName.match(logGroupRegex)) { | ||
|
|
||
| // sleep time between calls | ||
| await sleep(1000*(process.env.SUBSCRIBE_DELAY_SECONDS || 2)); // 5 seconds |
Contributor
There was a problem hiding this comment.
@himanshu219 Just One concern, as user has more lambda log groups(Lets say above 400 - 500), are there any chances that the lambda will go in timeout? I mean the 10-15 minutes time out for lambda?
Contributor
Author
There was a problem hiding this comment.
Yes it can go to time out.
Contributor
Author
There was a problem hiding this comment.
Customers should use more granular regex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.