-
Notifications
You must be signed in to change notification settings - Fork 137
Sourabh aws observability #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…y of old app which may have customer data.
…time without getting limit exception
…changing query to support new lookup changes.
|
LGTM am curious though why we are copying the folder, can't we append the app version in the folder name. |
|
Also why did we name the class SumoLogicAWSExplorer shouldn't it be jst SumoLogicExplorer assuming one can create any hierarchy for example if I want to create a Tracing hierarchy I can use it right?. |
The CF will call delete even If I just append the App version (as we are creating a new App, the ID gets changed and CF calls delete). So first we have to copy the folder and let CF to it task of delete |
If we change the Name, then update fails as the update will not find SumoLogicAWSExplorer custom resource for delete operation. Thus have to keep the name as it is. |
Yes, you will be able to create hierarchies with the same resource as it is generic in nature |
Changes related to AWS O V2. Moving to new hierarchy version. Added support for retries.