Skip to content

Conversation

@SumoSourabh
Copy link
Contributor

Changes related to AWS O V2. Moving to new hierarchy version. Added support for retries.

@himanshu219
Copy link
Contributor

himanshu219 commented Oct 6, 2020

LGTM am curious though why we are copying the folder, can't we append the app version in the folder name.

@himanshu219
Copy link
Contributor

himanshu219 commented Oct 6, 2020

Also why did we name the class SumoLogicAWSExplorer shouldn't it be jst SumoLogicExplorer assuming one can create any hierarchy for example if I want to create a Tracing hierarchy I can use it right?.

@SumoSourabh
Copy link
Contributor Author

LGTM am curious though why we are copying the folder, can't we append the app version in the folder name.

The CF will call delete even If I just append the App version (as we are creating a new App, the ID gets changed and CF calls delete). So first we have to copy the folder and let CF to it task of delete

@SumoSourabh
Copy link
Contributor Author

SumoSourabh commented Oct 6, 2020

Also why did we name the class SumoLogicAWSExplorer shouldn't it be jst SumoLogicExplorer assuming one can create any hierarchy for example if I want to create a Tracing hierarchy I can use it right?.

If we change the Name, then update fails as the update will not find SumoLogicAWSExplorer custom resource for delete operation. Thus have to keep the name as it is.

@SumoSourabh
Copy link
Contributor Author

Also why did we name the class SumoLogicAWSExplorer shouldn't it be jst SumoLogicExplorer assuming one can create any hierarchy for example if I want to create a Tracing hierarchy I can use it right?.

If we change the Name, then update fails as the update will not find SumoLogicAWSExplorer custom resource for delete operation. Thus have to keep the name as it is.

Yes, you will be able to create hierarchies with the same resource as it is generic in nature

@SumoSourabh SumoSourabh merged commit d45890d into main Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants