Skip to content

Added default value for tag filter #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2020
Merged

Added default value for tag filter #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions loggroup-lambda-connector/sam/packaged.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ Metadata:
- serverless
- loggroups
- cloudwatch
LicenseUrl: s3://appdevstore/LoggroupConnector/v1.0.3/5122657d5b9a0d3713e24d3a33eae431
LicenseUrl: s3://appdevstore/LoggroupConnector/v1.0.4/5122657d5b9a0d3713e24d3a33eae431
Name: sumologic-loggroup-connector
ReadmeUrl: s3://appdevstore/LoggroupConnector/v1.0.3/c98f2c0d986a3f55fbea539688ee6a2e
SemanticVersion: 1.0.3
ReadmeUrl: s3://appdevstore/LoggroupConnector/v1.0.4/c98f2c0d986a3f55fbea539688ee6a2e
SemanticVersion: 1.0.4
SourceCodeUrl: https://github.com/SumoLogic/sumologic-aws-lambda/loggroup-lambda-connector
SpdxLicenseId: Apache-2.0
Parameters:
Expand All @@ -45,13 +45,15 @@ Parameters:
Description: Select true for subscribing existing logs
LogGroupTags:
Type: CommaDelimitedList
Description: 'Enter comma separated keyvalue pairs for filtering logGroups using
tags. Ex KeyName1=string,KeyName2=string '
Default: ''
Description: Enter comma separated keyvalue pairs for filtering logGroups using
tags. Ex KeyName1=string,KeyName2=string. This is optional leave it blank if
tag based filtering is not needed.
Resources:
SumoLogGroupLambdaConnector:
Type: AWS::Serverless::Function
Properties:
CodeUri: s3://appdevstore/LoggroupConnector/v1.0.3/fef3de66919bef9861be16f25aec0343
CodeUri: s3://appdevstore/LoggroupConnector/v1.0.4/8822c7aea452b5df042a0d22e4ecd99d
Handler: loggroup-lambda-connector.handler
Runtime: nodejs10.x
Environment:
Expand Down
6 changes: 3 additions & 3 deletions loggroup-lambda-connector/sam/sam_package.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@ else
AWS_REGION="us-east-2"
fi

version="1.0.3"
version="1.0.4"

sam package --template-file template.yaml --s3-bucket $SAM_S3_BUCKET --output-template-file packaged.yaml --s3-prefix "LoggroupConnector/v$version"

sam deploy --template-file packaged.yaml --stack-name testingloggrpconnector --capabilities CAPABILITY_IAM --region $AWS_REGION --parameter-overrides LambdaARN="arn:aws:lambda:us-east-1:956882708938:function:SumoCWLogsLambda" LogGroupTags="env=prod,name=apiassembly" LogGroupPattern="test"
# sam deploy --template-file packaged.yaml --stack-name testingloggrpconnector --capabilities CAPABILITY_IAM --region $AWS_REGION --parameter-overrides LambdaARN="arn:aws:lambda:us-east-1:956882708938:function:SumoCWLogsLambda" LogGroupTags="env=prod,name=apiassembly" LogGroupPattern="test"

# sam publish --template packaged.yaml --region $AWS_REGION --semantic-version $version
sam publish --template packaged.yaml --region $AWS_REGION --semantic-version $version
# aws cloudformation describe-stack-events --stack-name testingloggrpconnector --region $AWS_REGION
# aws cloudformation get-template --stack-name testingloggrpconnector --region $AWS_REGION

5 changes: 3 additions & 2 deletions loggroup-lambda-connector/sam/template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Metadata:
LicenseUrl: ./LICENSE
Name: sumologic-loggroup-connector
ReadmeUrl: ../README.md
SemanticVersion: 1.0.3
SemanticVersion: 1.0.4
SourceCodeUrl: https://github.com/SumoLogic/sumologic-aws-lambda/loggroup-lambda-connector
SpdxLicenseId: Apache-2.0

Expand All @@ -47,7 +47,8 @@ Parameters:

LogGroupTags:
Type: CommaDelimitedList
Description: "Enter comma separated keyvalue pairs for filtering logGroups using tags. Ex KeyName1=string,KeyName2=string "
Default: ""
Description: "Enter comma separated keyvalue pairs for filtering logGroups using tags. Ex KeyName1=string,KeyName2=string. This is optional leave it blank if tag based filtering is not needed."

Resources:

Expand Down