Skip to content

Conversation

@sumoanema
Copy link
Collaborator

@sumoanema sumoanema commented Apr 24, 2024

…ate are in beta release).

Purpose of this pull request

This include details for include and exclude filter processing rules for logs and metrics which can be used for OTRM source template (Beta released) using otel collector.

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

https://sumologic.atlassian.net/browse/SUMO-231512
https://sumologic.atlassian.net/browse/SUMO-239785

…ate are in beta release). This include details for include and exclude filter processing rules for logs and metrics
@sumoanema sumoanema requested review from a team, JV0812, jpipkin1, kimsauce and mafsumo as code owners April 24, 2024 12:59
@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Apr 24, 2024
@sumoanema sumoanema added the do-not-merge Pull requests that should not be merged label Apr 24, 2024
Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sumoanema, I have a few suggestions.

I also went ahead and made some updates myself (see commits "Update metric filter examples section" and "Add cards to index page").

Let me know if you have any questions.

@sumoanema sumoanema requested a review from jpipkin1 April 25, 2024 10:12
@kimsauce kimsauce changed the title Inital draft for Processing rules for source template - (Source templ… OTEL Processing Rules for source template Apr 25, 2024
@jpipkin1
Copy link
Collaborator

@kimsauce, my apologies for adding "-otel" to the end of the file names earlier. I hope I didn't make too much trouble by doing that.

@jpipkin1
Copy link
Collaborator

@sumoanema, could you add the relevant Jira ticket number in the PR description?

Is this PR related to these tickets?
SUMO-231512
SUMO-231229

@kimsauce
Copy link
Collaborator

@kimsauce, my apologies for adding "-otel" to the end of the file names earlier. I hope I didn't make too much trouble by doing that.

Oh, I didn't even notice. I thought it was part of the initial commit. I removed it because the URL already contains the otel keyword (/opentelemetry-collector). Long URLs, while they don't ding SEO, aren't a great user experience.

@sumoanema
Copy link
Collaborator Author

sumoanema commented Apr 26, 2024

@sumoanema, could you add the relevant Jira ticket number in the PR description?

Is this PR related to these tickets? SUMO-231512 SUMO-231229

@jpipkin1 have added relevant jira to the PR

@kimsauce kimsauce enabled auto-merge May 3, 2024 16:34
@kimsauce kimsauce added this pull request to the merge queue May 3, 2024
Merged via the queue into main with commit d61f3da May 3, 2024
@kimsauce kimsauce deleted the proRuleOTRMST branch May 3, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed Contributor approved, listed in .clabot file do-not-merge Pull requests that should not be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants