Skip to content

Conversation

@kimsauce
Copy link
Collaborator

@kimsauce kimsauce commented Aug 18, 2024

Purpose of this pull request

Redesigned "Free trial" and "Contact support" buttons.

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

https://sumologic.atlassian.net/browse/DOCS-394

@kimsauce kimsauce self-assigned this Aug 18, 2024
@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Aug 18, 2024
@kimsauce kimsauce changed the title Top navigation bar improvements Top navigation bar - collapsible "contributing" banner, UX/CSS improvements to CTA buttons Aug 18, 2024
@kimsauce kimsauce added the do-not-merge Pull requests that should not be merged label Aug 18, 2024
@kimsauce kimsauce marked this pull request as draft August 18, 2024 05:15
@kimsauce kimsauce changed the title Top navigation bar - collapsible "contributing" banner, UX/CSS improvements to CTA buttons Top navigation bar - add contributing banner, UX/CSS improvements to CTA buttons Aug 18, 2024
@kimsauce kimsauce changed the title Top navigation bar - add contributing banner, UX/CSS improvements to CTA buttons Top nav - contributing banner, CTA button, support Sep 1, 2024
@kimsauce kimsauce changed the title Top nav - contributing banner, CTA button, support Top nav - Free trial and Support buttons Sep 19, 2024
@kimsauce kimsauce marked this pull request as ready for review September 19, 2024 05:26
Copy link
Collaborator

@JV0812 JV0812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion.

Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kimsauce, when I click "Contribute to Docs", the Support button changes to this:
Screenshot 2024-09-19 at 8 49 59 AM

Also, the dark down arrow in the light mode is not readable. Could you make the down arrow blue so that it will show up in both light and dark mode?

@kimsauce kimsauce changed the title Top nav - Free trial and Support buttons [Site Redesign] Top nav - Free trial and Support buttons Sep 19, 2024
@kimsauce kimsauce added the doc:site tech Site/tool maintenance, dependencies, updates label Sep 19, 2024
kimsauce and others added 6 commits September 22, 2024 22:29
Co-authored-by: Jagadisha V <129049263+JV0812@users.noreply.github.com>
Co-authored-by: Jagadisha V <129049263+JV0812@users.noreply.github.com>
@kimsauce kimsauce changed the title [Site Redesign] Top nav - Free trial and Support buttons "Free Trial" and "Support" nav buttons Oct 11, 2024
@kimsauce kimsauce requested a review from jpipkin1 October 11, 2024 00:04
@kimsauce
Copy link
Collaborator Author

@kimsauce, when I click "Contribute to Docs", the Support button changes to this...

Also, the dark down arrow in the light mode is not readable. Could you make the down arrow blue so that it will show up in both light and dark mode?

Fixed the "Contribute to Docs" issue and I made the text + arrow color both white in light + dark mode. Thanks for your review!
Screenshot 2024-10-10 at 4 48 34 PM

Screenshot 2024-10-10 at 4 48 23 PM

@kimsauce kimsauce added this pull request to the merge queue Oct 11, 2024
@kimsauce kimsauce removed the do-not-merge Pull requests that should not be merged label Oct 11, 2024
Merged via the queue into main with commit c9cb46c Oct 11, 2024
4 checks passed
@kimsauce kimsauce deleted the DOCS-394 branch October 11, 2024 00:31
@kimsauce kimsauce restored the DOCS-394 branch October 11, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed Contributor approved, listed in .clabot file doc:site tech Site/tool maintenance, dependencies, updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants