Skip to content

Conversation

@JV0812
Copy link
Collaborator

@JV0812 JV0812 commented Sep 26, 2024

Purpose of this pull request

This pull request is to create a new beta doc for Azure Metrics source.

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

Azure Metrics Source [Beta] setup documentation

@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Sep 26, 2024
@JV0812 JV0812 self-assigned this Sep 26, 2024
@JV0812 JV0812 added the do-not-merge Pull requests that should not be merged label Sep 26, 2024
Copy link
Contributor

@samjsong samjsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, thank you very much Jagadisha! I left some comment suggestions, please let me know if you have any questions or doubts. Thank you

JV0812 and others added 6 commits September 27, 2024 10:22
…s-source.md

Co-authored-by: Sam Song <sam.jin.song@gmail.com>
…s-source.md

Co-authored-by: Sam Song <sam.jin.song@gmail.com>
…s-source.md

Co-authored-by: Sam Song <sam.jin.song@gmail.com>
…s-source.md

Co-authored-by: Sam Song <sam.jin.song@gmail.com>
Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, @JV0812. I have only a few minor suggestions.

JV0812 and others added 3 commits September 30, 2024 15:35
…s-source.md

Co-authored-by: John Pipkin (Sumo Logic) <jpipkin@sumologic.com>
…s-source.md

Co-authored-by: John Pipkin (Sumo Logic) <jpipkin@sumologic.com>
…s-source.md

Co-authored-by: John Pipkin (Sumo Logic) <jpipkin@sumologic.com>
@samjsong
Copy link
Contributor

samjsong commented Oct 2, 2024

Thank you! This looks great. Please feel free to merge at any time, since this is a beta source the documentation will not be reachable without the url which we will share with customers once the beta is ready tomorrow.

@kimsauce kimsauce enabled auto-merge October 2, 2024 23:25
@kimsauce kimsauce added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit c204bcb Oct 2, 2024
@kimsauce kimsauce deleted the Azure-Metrics-Source branch October 2, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed Contributor approved, listed in .clabot file do-not-merge Pull requests that should not be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants