Skip to content

Legacy 301 fixes #4664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 17, 2024
Merged

Legacy 301 fixes #4664

merged 10 commits into from
Oct 17, 2024

Conversation

@kimsauce
Copy link
Collaborator

@kimsauce kimsauce commented Oct 17, 2024 •
edited
Loading

Purpose of this pull request

Legacy 301 fixes

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Oct 17, 2024
@kimsauce kimsauce self-assigned this Oct 17, 2024
@kimsauce kimsauce enabled auto-merge October 17, 2024 08:19
jpipkin1
jpipkin1 reviewed Oct 17, 2024
View reviewed changes
jpipkin1
jpipkin1 requested changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kimsauce, I found one thing you need to fix.

@kimsauce kimsauce requested a review from jpipkin1 October 17, 2024 17:51
jpipkin1
jpipkin1 approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @kimsauce!

@kimsauce kimsauce added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit 1e86208 Oct 17, 2024
7 checks passed
@kimsauce kimsauce deleted the 404s branch October 17, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpipkin1 jpipkin1 jpipkin1 approved these changes

@JV0812 JV0812 Awaiting requested review from JV0812 JV0812 is a code owner

@mafsumo mafsumo Awaiting requested review from mafsumo mafsumo is a code owner

Assignees

@kimsauce kimsauce

Labels

cla-signed Contributor approved, listed in .clabot file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kimsauce @jpipkin1 @JV0812