Skip to content

Conversation

@amee-sumo
Copy link
Collaborator

@amee-sumo amee-sumo commented Dec 3, 2024

Purpose of this pull request

This pull request is created for an official documentation for C2C TrustLogin.

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

https://sumologic.atlassian.net/browse/DOCS-581

@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Dec 3, 2024
@amee-sumo amee-sumo added the do-not-merge Pull requests that should not be merged label Dec 3, 2024
@jpipkin1 jpipkin1 requested a review from a team as a code owner December 3, 2024 17:25
Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @amee-sumo! I have only a few suggestions. The main thing is that I think "Trust Login" needs to be changed to "TrustLogin". But I've seen it both ways on the official web site.

Note that I added the source to a product list article (see commit "Add to the product list").

amee-sumo and others added 5 commits December 4, 2024 10:22
…amework/trust-login-source.md

Co-authored-by: John Pipkin (Sumo Logic) <jpipkin@sumologic.com>
…amework/trust-login-source.md

Co-authored-by: John Pipkin (Sumo Logic) <jpipkin@sumologic.com>
…amework/trust-login-source.md

Co-authored-by: John Pipkin (Sumo Logic) <jpipkin@sumologic.com>
…amework/trust-login-source.md

Co-authored-by: John Pipkin (Sumo Logic) <jpipkin@sumologic.com>
@amee-sumo amee-sumo requested a review from jpipkin1 December 4, 2024 06:32
@amee-sumo amee-sumo self-assigned this Dec 4, 2024
Copy link
Collaborator

@JV0812 JV0812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @amee-sumo!

@yleiferman yleiferman added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit d876ac5 Dec 4, 2024
7 checks passed
@yleiferman yleiferman deleted the Trust-Login-C2C-(Apps) branch December 4, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed Contributor approved, listed in .clabot file do-not-merge Pull requests that should not be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants