SUMO-251499: Adding monitor's information to OTEL Apps Set1 #4852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chetanchoudhary-sumo
requested review from
a team,
JV0812,
amee-sumo,
jpipkin1,
kimsauce and
mafsumo
as code owners
JV0812
requested changes
Dec 9, 2024
Collaborator
JV0812
left a comment
JV0812
left a comment
There was a problem hiding this comment.
@chetanchoudhary-sumo I have fixed the table title and added the word "Count" for the values in Alert condition and recover condition column. Can you please fix the same for rest of the tables?
Collaborator
|
@chetanchoudhary-sumo, can this PR be merged? |
Collaborator
Author
Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request...
Select the type of change
Ticket (if applicable)