Skip to content

Cisco AMP - Apps #4894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 20, 2024
Merged

Cisco AMP - Apps #4894

merged 8 commits into from
Dec 20, 2024

Conversation

@amee-sumo
Copy link
Collaborator

@amee-sumo amee-sumo commented Dec 19, 2024 •
edited by JV0812
Loading

Purpose of this pull request

This pull request is to create a new don Cisco AMP app.

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

https://sumologic.atlassian.net/browse/DOCS-609

@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Dec 19, 2024
@amee-sumo amee-sumo self-assigned this Dec 19, 2024
@amee-sumo amee-sumo added doc:new New section or topic to content do-not-merge Pull requests that should not be merged labels Dec 19, 2024
JV0812
JV0812 reviewed Dec 19, 2024
View reviewed changes
jpipkin1
jpipkin1 approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @amee-sumo!

@amee-sumo @JV0812
Update docs/integrations/saas-cloud/cisco-amp.md
60e8c4c 
Co-authored-by: Jagadisha V <129049263+JV0812@users.noreply.github.com>
JV0812
JV0812 reviewed Dec 20, 2024
View reviewed changes
JV0812
JV0812 reviewed Dec 20, 2024
View reviewed changes
JV0812
JV0812 reviewed Dec 20, 2024
View reviewed changes
JV0812
JV0812 reviewed Dec 20, 2024
View reviewed changes
JV0812
JV0812 reviewed Dec 20, 2024
View reviewed changes
JV0812
JV0812 reviewed Dec 20, 2024
View reviewed changes
JV0812
JV0812 reviewed Dec 20, 2024
View reviewed changes
JV0812
JV0812 reviewed Dec 20, 2024
View reviewed changes
JV0812
JV0812 reviewed Dec 20, 2024
View reviewed changes
JV0812
JV0812 requested changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@JV0812 JV0812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fixes

JV0812
JV0812 reviewed Dec 20, 2024
View reviewed changes
JV0812
JV0812 reviewed Dec 20, 2024
View reviewed changes
@himanshu219 himanshu219 requested a review from JV0812 December 20, 2024 13:35
JV0812
JV0812 approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@JV0812 JV0812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JV0812 JV0812 enabled auto-merge December 20, 2024 13:37
@JV0812 JV0812 added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit a014662 Dec 20, 2024
7 checks passed
@JV0812 JV0812 deleted the Cisco-AMP-App branch December 20, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpipkin1 jpipkin1 jpipkin1 approved these changes

@JV0812 JV0812 JV0812 approved these changes

@kimsauce kimsauce Awaiting requested review from kimsauce kimsauce is a code owner

@mafsumo mafsumo Awaiting requested review from mafsumo mafsumo is a code owner

+1 more reviewer

@himanshu219 himanshu219 himanshu219 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@amee-sumo amee-sumo

Labels

cla-signed Contributor approved, listed in .clabot file do-not-merge Pull requests that should not be merged doc:new New section or topic to content

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@amee-sumo @himanshu219 @jpipkin1 @JV0812