Azure Container Instances document #5101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachin-sumologic
requested review from
a team,
JV0812,
amee-sumo,
jpipkin1,
kimsauce and
mafsumo
as code owners
Collaborator
|
@sachin-sumologic, I added the new article to the index page, the product list article, and the left nav bar. I also added a logo, since your PR didn't have one. See commit "Add article to left nav". |
jpipkin1
reviewed
Feb 24, 2025
jpipkin1
requested changes
Feb 24, 2025
Collaborator
jpipkin1
left a comment
jpipkin1
left a comment
There was a problem hiding this comment.
@sachin-sumologic, I made a few minor changes (see commit "Updates from review").
You need to complete a "to do" you left in the article.
kimsauce
reviewed
Feb 24, 2025
kimsauce
reviewed
Feb 24, 2025
kimsauce
reviewed
Feb 24, 2025
kimsauce
reviewed
Feb 24, 2025
kimsauce
previously requested changes
Feb 24, 2025
Collaborator
kimsauce
left a comment
kimsauce
left a comment
There was a problem hiding this comment.
Double-checking if this doc needs a CID?
Co-authored-by: Kim (Sumo Logic) <56411016+kimsauce@users.noreply.github.com>
Co-authored-by: Kim (Sumo Logic) <56411016+kimsauce@users.noreply.github.com>
Co-authored-by: Kim (Sumo Logic) <56411016+kimsauce@users.noreply.github.com>
himanshu219
reviewed
Feb 27, 2025
himanshu219
reviewed
Feb 27, 2025
himanshu219
reviewed
Feb 27, 2025
himanshu219
reviewed
Feb 27, 2025
himanshu219
previously requested changes
Feb 27, 2025
Contributor
himanshu219
left a comment
himanshu219
left a comment
There was a problem hiding this comment.
Let's put all the files
Dockerfile and yaml file in S3 in same folder as screenshots
This will allow us to update them later
auto-merge was automatically disabled
February 27, 2025 06:23
Head branch was pushed to by a user without write access
JV0812
reviewed
Feb 27, 2025
JV0812
reviewed
Feb 27, 2025
JV0812
dismissed stale reviews from himanshu219 and kimsauce
Incorporated your comments.
JV0812
reviewed
Feb 27, 2025
JV0812
reviewed
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request...
Select the type of change
Ticket (if applicable)
SUMO-255285